Closed Bug 1411823 Opened 7 years ago Closed 7 years ago

Intermittent /IndexedDB/keypath-exceptions.htm | Array key conversion should not invoke prototype getters - assert_equals: Prototype getter should not be called expected 0 but got 3

Categories

(Core :: Storage: IndexedDB, defect, P3)

Product:
Core
Component:
Storage: IndexedDB
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bevis)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file)

Disable IndexedDB/keypath-exceptions.htm.
1.07 KB, patch
jgraham
: review+
Details | Diff | Splinter Review 
In the last week there have been 38 failures. The rate of failures is pretty much the same across all platforms(Linux, MacOS, Windows).
Half of the build types affected are Debug and the rest of them are pgo and opt.

Here is an example of a recent log
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=140003401&lineNumber=2618

This is the part where the test fails:
[task 2017-10-26T21:35:39.601Z] 21:35:39     INFO - @http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:206:5
[task 2017-10-26T21:35:39.601Z] 21:35:39     INFO - indexeddb_test/</open.onupgradeneeded<@http://web-platform.test:8000/IndexedDB/support.js:125:7
[task 2017-10-26T21:35:39.601Z] 21:35:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
[task 2017-10-26T21:35:39.601Z] 21:35:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1513:20
[task 2017-10-26T21:35:39.602Z] 21:35:39     INFO - EventHandlerNonNull*indexeddb_test/<@http://web-platform.test:8000/IndexedDB/support.js:114:28
[task 2017-10-26T21:35:39.602Z] 21:35:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
[task 2017-10-26T21:35:39.603Z] 21:35:39     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:528:13
[task 2017-10-26T21:35:39.603Z] 21:35:39     INFO - indexeddb_test@http://web-platform.test:8000/IndexedDB/support.js:108:3
[task 2017-10-26T21:35:39.604Z] 21:35:39     INFO - @http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:10:1
[task 2017-10-26T21:35:39.604Z] 21:35:39     INFO - TEST-UNEXPECTED-FAIL | /IndexedDB/keypath-exceptions.htm | Array key conversion should not invoke prototype getters - assert_equals: Prototype getter should not be called expected 0 but got 3
[task 2017-10-26T21:35:39.605Z] 21:35:39     INFO - request.onsuccess<@http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:264:7
[task 2017-10-26T21:35:39.605Z] 21:35:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
[task 2017-10-26T21:35:39.606Z] 21:35:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1513:20
[task 2017-10-26T21:35:39.606Z] 21:35:39     INFO - EventHandlerNonNull*@http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:263:25
[task 2017-10-26T21:35:39.607Z] 21:35:39     INFO - indexeddb_test/</open.onsuccess<@http://web-platform.test:8000/IndexedDB/support.js:134:11
[task 2017-10-26T21:35:39.608Z] 21:35:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
[task 2017-10-26T21:35:39.609Z] 21:35:39     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1513:20
[task 2017-10-26T21:35:39.612Z] 21:35:39     INFO - EventHandlerNonNull*indexeddb_test/<@http://web-platform.test:8000/IndexedDB/support.js:131:24
[task 2017-10-26T21:35:39.612Z] 21:35:39     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
[task 2017-10-26T21:35:39.612Z] 21:35:39     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:528:13
[task 2017-10-26T21:35:39.613Z] 21:35:39     INFO - indexeddb_test@http://web-platform.test:8000/IndexedDB/support.js:108:3
[task 2017-10-26T21:35:39.613Z] 21:35:39     INFO - @http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:10:1
[task 2017-10-26T21:35:39.614Z] 21:35:39     INFO - TEST-OK | /IndexedDB/keypath-exceptions.htm | took 468ms
[task 2017-10-26T21:35:39.945Z] 21:35:39     INFO - Browser exited with return code 0


:jgraham : can you please take a look at this bug?
Flags: needinfo?(james)
Whiteboard: [stockwell needswork]
bkelly - I feel like you know something a bout IndexedDB, care to look at this?
Component: web-platform-tests → DOM: IndexedDB
Flags: needinfo?(james) → needinfo?(bkelly)
Product: Testing → Core
Version: Version 3 → unspecified
I know enough about IDB to stay away from it!  Maybe Jan or Andrew can help here.
Flags: needinfo?(bkelly)
:overholt, one more for your queue, this was in the wrong component initially and missed the robot to add [stockwell needswork:owner]
Flags: needinfo?(overholt)
Whiteboard: [stockwell needswork] → [stockwell needswork:owner]
There have been 59 failures in the last week.
Almost half of them occur on OS X 10.10 and windows10-64 platforms and on opt and pgo build types respectively.
There are other platforms affected too: linux, linux x64, linux32-stylo-disabled, windows10-64-stylo-disabled.
The most affected build type is the debug one.

Here is a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=143082646&lineNumber=9471
And a relevant snippet from it:
9:15:21     INFO - EventHandlerNonNull*indexeddb_test/<@http://web-platform.test:8000/IndexedDB/support.js:114:28
9467
09:15:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
9468
09:15:21     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:528:13
9469
09:15:21     INFO - indexeddb_test@http://web-platform.test:8000/IndexedDB/support.js:108:3
9470
09:15:21     INFO - @http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:10:1
9471
09:15:21     INFO - TEST-UNEXPECTED-FAIL | /IndexedDB/keypath-exceptions.htm | Array key conversion should not invoke prototype getters - assert_equals: Prototype getter should not be called expected 0 but got 3
9472
09:15:21     INFO - request.onsuccess<@http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:264:7
9473
09:15:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
9474
09:15:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1513:20
9475
09:15:21     INFO - EventHandlerNonNull*@http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:263:25
9476
09:15:21     INFO - indexeddb_test/</open.onsuccess<@http://web-platform.test:8000/IndexedDB/support.js:134:11
9477
09:15:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
9478
09:15:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1513:20
9479
09:15:21     INFO - EventHandlerNonNull*indexeddb_test/<@http://web-platform.test:8000/IndexedDB/support.js:131:24
9480
09:15:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1489:20
9481
09:15:21     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:528:13
9482
09:15:21     INFO - indexeddb_test@http://web-platform.test:8000/IndexedDB/support.js:108:3
9483
09:15:21     INFO - @http://web-platform.test:8000/IndexedDB/keypath-exceptions.htm:10:1
9484
09:15:21     INFO - TEST-OK | /IndexedDB/keypath-exceptions.htm | took 1174ms
Bevis may be able to provide some insight here.
Flags: needinfo?(overholt) → needinfo?(btseng)
Priority: -- → P3
The support of keypath evaluation is incomplete and has to be rewritten in bug 1404274, so there is no much sense to fix this particular failure for now.
I'd like to disable it first and revisit it in bug 1404274.
Assignee: nobody → btseng
Flags: needinfo?(btseng)
Attachment #8928086 - Flags: review?(james)
Depends on: 1404274
Comment on attachment 8928086 [details] [diff] [review]
Disable IndexedDB/keypath-exceptions.htm.

Review of attachment 8928086 [details] [diff] [review]:
-----------------------------------------------------------------

Please don't forget to re-enable this later :)
Attachment #8928086 - Flags: review?(james) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1382881c394
Disable IndexedDB/keypath-exceptions.htm. r=jgraham
https://hg.mozilla.org/mozilla-central/rev/a1382881c394
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
https://hg.mozilla.org/releases/mozilla-beta/rev/139db886b646
status-firefox58: affected → fixed
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: