1411825 - Don't run mozscreenshots with "-u mochitests" so we can capture without MOZSCREENSHOTS_SETS on try

Status: RESOLVED FIXED

(Testing :: mozscreenshots, enhancement)

Description

[Matthew N. [:MattN]]

IIRC, if we rename mochitest-browser-screenshots to not include the substring "mochitest" then the job won't run with "-u mochitest". The only reason we don't capture all images for "-u mochitest-browser-screenshots" is because many people ask for "-u mochitest" but don't intend to look at the screenshots which is a waste. If we only capture when pushers explicitly ask for screenshots then we don't need to require MOZSCREENSHOTS_SETS.

Comment 1

[Matthew N. [:MattN]]

https://dxr.mozilla.org/mozilla-central/rev/a97fb1c39d51a7337b46957bde4273bd308b796a/taskcluster/taskgraph/try_option_syntax.py#75-76

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1411825 - Stop running browser-screenshots for "-u mochitests" and "-u all".

Review commit: https://reviewboard.mozilla.org/r/193208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193208/

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1411825 - Capture browser-screenshots on try without MOZSCREENSHOTS_SETS.

Review commit: https://reviewboard.mozilla.org/r/193210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193210/

Comment 4

[Matthew N. [:MattN]]

Try runs look good:
* -u mochitests (none)
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=327eff26b5ac08c6f10deca30c665fccc6bbbfa1&filter-tier=1&filter-tier=2&filter-tier=3
* -u browser-screenshots-e10s[Ubuntu] (works)
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae4dc4d897e0fc00e35b87ca006b15286f9420f2&filter-tier=1&filter-tier=2&filter-tier=3

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8922208 [details]
Bug 1411825 - Capture browser-screenshots on try without MOZSCREENSHOTS_SETS.

https://reviewboard.mozilla.org/r/193210/#review198616

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8922207 [details]
Bug 1411825 - Stop running browser-screenshots for "-u mochitests" and "-u all".

https://reviewboard.mozilla.org/r/193208/#review198642

Lgtm.

Comment 7

[Matthew N. [:MattN]]

The server is now ready to handle the new job names: https://github.com/mnoorenberghe/mozscreenshots/commit/82e1124eeadc59dd151317dcb4bd836bce1e27cf

And I confirmed that a comparison between before an after works (mixing old and new) so this is ready to land.

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30dcb85a958d
Stop running browser-screenshots for "-u mochitests" and "-u all". r=ahal
https://hg.mozilla.org/integration/autoland/rev/9ca2c544da67
Capture browser-screenshots on try without MOZSCREENSHOTS_SETS. r=bgrins

Comment 9

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/30dcb85a958d
https://hg.mozilla.org/mozilla-central/rev/9ca2c544da67