1411860 - Make the creation of nsDisplaySubDocument unconditional

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Ethan Lin[:ethlin]]

The conditional creation of nsDisplaySubDocument may cause wrong painting count when using retained display list. A related testcase is "layout/base/tests/test_scroll_event_ordering.html".

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1411860 - Create nsDisplaySubDocument unconditionally.

Review commit: https://reviewboard.mozilla.org/r/193240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193240/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8922218 [details]
Bug 1411860 - Create nsDisplaySubDocument unconditionally.

https://reviewboard.mozilla.org/r/193240/#review198476

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/9facbd5bc72a
Create nsDisplaySubDocument unconditionally. r=mattwoodrow

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c6307a06e78
Create nsDisplaySubDocument unconditionally. r=mattwoodrow

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a402f6926b4b
Backed out 2 changesets (bug 1411860, bug 1411886) for failing reftests layout/reftests/bugs/409084-1{a,b}.html on OS X. r=backout on a CLOSED TREE

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1411860 and bug 1411886 for failing reftests layout/reftests/bugs/409084-1{a,b}.html on OS X:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a402f6926b4b5aa6777282d604a903126ee2610c

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=be44e8cd8503ba234372f7fe3d120607f1f00aea&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Next push which ran it on more OS X variants: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6eac731d5c33a24ef8d69a410554f201ab21a9ab&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=139877411&repo=mozilla-inbound

REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1509028499/build/tests/reftest/tests/layout/reftests/bugs/409084-1a.html == file:///Users/cltbld/tasks/task_1509028499/build/tests/reftest/tests/layout/reftests/bugs/409084-1-ref.html | image comparison, max difference: 1, number of differing pixels: 460
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1509028499/build/tests/reftest/tests/layout/reftests/bugs/409084-1b.html == file:///Users/cltbld/tasks/task_1509028499/build/tests/reftest/tests/layout/reftests/bugs/409084-1-ref.html | image comparison, max difference: 1, number of differing pixels: 460

Comment 7

[Ethan Lin[:ethlin]]

I should override GetLayerState for nsDisplaySubDocument and return different state according to 'mShouldFlatten'.

Comment 8

[Ethan Lin[:ethlin]]

The failure is fixed after overriding the GetLayerState.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5a522c41161a219410362dca1192c850c477f69&selectedJob=140083634

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c215bc2abdd
Create nsDisplaySubDocument unconditionally. r=mattwoodrow

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b47ad61d282f
(follow-up) add display list changes for the bug. r=me

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5c215bc2abdd
https://hg.mozilla.org/mozilla-central/rev/b47ad61d282f