1411866 - Update cubeb from upstream to cf5ddc5

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Alex Chronopoulos [:achronop]]

Pick commits:

cf5ddc5 audiounit: unregister system listeners after failed reinit.
a0f5dc6 audiounit: reinit fail when no media devices (Bug 1409224)
6e2280a Elaborate the build instructions for Windows
7c69071 Disable MSBuild mode in AppVeyor.
ede79a7 os2: disable visibility attribute
c2bd582 audiounit: advance active stream counter earlier in stream init (#367)
ee7c747 Mute test deadlock
57eae36 Use _WIN32 rather than WIN32 in cubeb_utils.h.
871456d CMake: Generate and install CMake config files

Comment 1

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40d9e6d89048a9493505cb520ff8f989d650baad

Comment 2

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80f6a508d20760644b70b035bb96852458b2a7c6
Bug 1411866 - Update cubeb from upstream to cf5ddc5. r=padenot,kinetik

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80f6a508d207
Update cubeb from upstream to cf5ddc5. r=padenot,kinetik

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/80f6a508d207

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1411866 - Uplift cubeb import to cf5ddc5.

Approval Request Comment
[Feature/Bug causing the regression]:Bug 1405258
[User impact if declined]: Crashes when no media device attached on the system.
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]:Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
Scenario 1: Playback or WebRTC, request on a system that does not have any media device installed.
Scenario 2: Unplug last media device during audio playback or WebRTC call.
[List of other uplifts needed for the feature/fix]:N/A
[Is the change risky?]:No
[Why is the change risky/not risky?]: It is a small fix. Replace assert check with properly fail and abort. 
[String changes made/needed]:No

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Anthony, is this a low risk change? The size of this change is worrisome. I'd like a second opinion on whether to take it in 57 or not.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

This doesn't happy to the beta branch (but should be easy to fix)

grafting 432451:80f6a508d207 "Bug 1411866 - Update cubeb from upstream to cf5ddc5. r=padenot,kinetik"
merging media/libcubeb/README_MOZILLA
 warning: conflicts while merging media/libcubeb/README_MOZILLA! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 8

[Alex Chronopoulos [:achronop]]

You try to merge the m-c patch. The right patch for beta is the one attached on the bug. See on the "Attachments" please.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

ok, sorry, my bad.

Comment 10

[Alex Chronopoulos [:achronop]]

No reason to be sorry! Thank you for taking care!

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8923328 [details] [diff] [review]
Bug 1411866 - Uplift cubeb import to cf5ddc5.

Philipp/Marcia mentioned that this fix has helped on Nightly, that's a good data point, taking it. Beta57+

Comment 12

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b1dc78a5838b

Comment 13

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Ritu Kothari (:ritu) from comment #6)
> Hi Anthony, is this a low risk change? The size of this change is worrisome.
> I'd like a second opinion on whether to take it in 57 or not.

For the record, it isn't high risk but it also isn't a severe problem.

Comment 16

[Simon Basca [:SimonB]]

As Bug 1409224 was verified fixed, the update cubeb from upstream to cf5ddc5 was successful. 

Also note that the scenarios mentioned in Comment 5 were tested when Bug 1409224 was verified.