Linux repacks detected as unofficial builds

RESOLVED FIXED in Firefox 58

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Dexter, Assigned: Mardak)

Tracking

Trunk
Firefox 59
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed, firefox59 fixed)

Details

User Story

https://github.com/mozilla/activity-stream/compare/9fdffe5455e78e8e300623bf3eb033a66bad7ea0...2da0b43b8347d793a44623ef1f71f5b5d344a47c

Attachments

(1 attachment)

(Reporter)

Description

a year ago
While working on some bug, I stumbled upon this [1] line of code that tries to determine whether a build is a local developer build or not:

> const IS_UNOFFICIAL_BUILD = Services.prefs.getStringPref("app.update.channel") === "default";

I think this should be done by checking MOZILLA_OFFICIAL [2] and not the channel. There are some official Linux repacks (and there might be other cases) that leave the channel name as "default" and this could would misinterpret these cases [3].

[1] - http://searchfox.org/mozilla-central/rev/dd47bee6468de7e1221b4d006342ad6b9813d0e5/browser/extensions/activity-stream/lib/ActivityStreamPrefs.jsm#80
[2] - http://searchfox.org/mozilla-central/source/toolkit/modules/AppConstants.jsm#42
[3] - https://sql.telemetry.mozilla.org/queries/47690#table
(Assignee)

Updated

a year ago
Ed, is this something that should be tracked for 57?
Flags: needinfo?(edilee)
(Assignee)

Comment 2

a year ago
I noted in https://github.com/mozilla/activity-stream/issues/3769 that the only pref that relies on this behavior is the telemetry pref (browser.newtabpage.activity-stream.telemetry). So that means we won't get data from these types of repacks.

Dexter, any idea how widespread this might be? E.g., total number of users?
Flags: needinfo?(edilee) → needinfo?(alessio.placitelli)
(Reporter)

Comment 3

a year ago
(In reply to Ed Lee :Mardak from comment #2)
> I noted in https://github.com/mozilla/activity-stream/issues/3769 that the
> only pref that relies on this behavior is the telemetry pref
> (browser.newtabpage.activity-stream.telemetry). So that means we won't get
> data from these types of repacks.
> 
> Dexter, any idea how widespread this might be? E.g., total number of users?

I'm not sure off the top of my head, sorry :( I don't think this is urgent FWIW, but I think it's still worth fixing.
Flags: needinfo?(alessio.placitelli)
(Reporter)

Comment 4

a year ago
For example, I'm sure this affects Fedora users (but it doesn't affect Ubuntu users).
status-firefox57: --- → wontfix
(Assignee)

Comment 5

a year ago
Fixed by https://github.com/mozilla/activity-stream/pull/3844 to be uplifted via bug 1415812.
Assignee: nobody → edilee
Blocks: 1415812
(Assignee)

Comment 6

a year ago
https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
status-firefox58: affected → fixed
Bug 1415812 has been uplifted to 58. We should not mark 58 fixed.
status-firefox58: fixed → affected
Sorry for typo in comment #7. What I meant is bug 1415812 has not been uplift to 58.
(Assignee)

Comment 9

a year ago
gchang says this bug has missed 58.0b8. It doesn't have a patch with beta approval flag. Please attach the appropriate patch without install.rdf.in changes and request approval ASAP.
Flags: needinfo?(andrei.br92)
Comment hidden (mozreview-request)
Comment on attachment 8933376 [details]
Bug 1411867 - Linux repacks detected as unofficial builds.

Approval Request Comment
[Feature/Bug causing the regression]: https://github.com/mozilla/activity-stream/commit/59d8e5e1e72d3496535392d2f484b8b413f71ea6
[User impact if declined]: incorrect telemetry data for subset of linux distros
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: change only affects telemetry 
[String changes made/needed]: no
Flags: needinfo?(andrei.br92)
Attachment #8933376 - Flags: approval-mozilla-beta?

Comment 12

a year ago
mozreview-review
Comment on attachment 8933376 [details]
Bug 1411867 - Linux repacks detected as unofficial builds.

https://reviewboard.mozilla.org/r/204298/#review209878

R+
Attachment #8933376 - Flags: review?(khudson) → review+
Comment on attachment 8933376 [details]
Bug 1411867 - Linux repacks detected as unofficial builds.

Fix an incorrect telemetry colletion issue. Beta58+.
Attachment #8933376 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 14

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/7fe3a16c32f7
status-firefox58: affected → fixed
Flags: in-testsuite+
(Assignee)

Updated

a year ago
User Story: (updated)
You need to log in before you can comment on or make changes to this bug.