Linux repacks detected as unofficial builds

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Activity Streams: Newtab
RESOLVED FIXED
27 days ago
4 days ago

People

(Reporter: Dexter, Assigned: Mardak)

Tracking

Trunk
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 affected, firefox59 fixed)

Details

(Reporter)

Description

27 days ago
While working on some bug, I stumbled upon this [1] line of code that tries to determine whether a build is a local developer build or not:

> const IS_UNOFFICIAL_BUILD = Services.prefs.getStringPref("app.update.channel") === "default";

I think this should be done by checking MOZILLA_OFFICIAL [2] and not the channel. There are some official Linux repacks (and there might be other cases) that leave the channel name as "default" and this could would misinterpret these cases [3].

[1] - http://searchfox.org/mozilla-central/rev/dd47bee6468de7e1221b4d006342ad6b9813d0e5/browser/extensions/activity-stream/lib/ActivityStreamPrefs.jsm#80
[2] - http://searchfox.org/mozilla-central/source/toolkit/modules/AppConstants.jsm#42
[3] - https://sql.telemetry.mozilla.org/queries/47690#table
(Assignee)

Updated

27 days ago
Ed, is this something that should be tracked for 57?
Flags: needinfo?(edilee)
(Assignee)

Comment 2

26 days ago
I noted in https://github.com/mozilla/activity-stream/issues/3769 that the only pref that relies on this behavior is the telemetry pref (browser.newtabpage.activity-stream.telemetry). So that means we won't get data from these types of repacks.

Dexter, any idea how widespread this might be? E.g., total number of users?
Flags: needinfo?(edilee) → needinfo?(alessio.placitelli)
(Reporter)

Comment 3

26 days ago
(In reply to Ed Lee :Mardak from comment #2)
> I noted in https://github.com/mozilla/activity-stream/issues/3769 that the
> only pref that relies on this behavior is the telemetry pref
> (browser.newtabpage.activity-stream.telemetry). So that means we won't get
> data from these types of repacks.
> 
> Dexter, any idea how widespread this might be? E.g., total number of users?

I'm not sure off the top of my head, sorry :( I don't think this is urgent FWIW, but I think it's still worth fixing.
Flags: needinfo?(alessio.placitelli)
(Reporter)

Comment 4

26 days ago
For example, I'm sure this affects Fedora users (but it doesn't affect Ubuntu users).
status-firefox57: --- → wontfix
(Assignee)

Comment 5

7 days ago
Fixed by https://github.com/mozilla/activity-stream/pull/3844 to be uplifted via bug 1415812.
Assignee: nobody → edilee
Blocks: 1415812
(Assignee)

Comment 6

4 days ago
https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93
Status: NEW → RESOLVED
Last Resolved: 4 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.