1411889 - Add telemetry to track netmonitor update time on page reload

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1405585 introduced a generic way to track how much time each panel takes to update after a page reload. This bug added support for the inspector.

Now all other panels should emit a "reloaded" event on its Panel object whenever it consider it is fully updated after a page reload.
This is not obvious and will require specific decision for each tool.

Here for the netmonitor, we should wait for all ressources loaded before "load" event to be fully displayed in the netmonitor. We should ignore any XHR or dynamic request.

Comment 1

[Alexandre Poirot [:ochameau]]

This bug depends on bug 1372115 as the error on the backend side makes it so that some requests (the requests for js files that are put in bytecode case) stay pending for ever in the payload queue and so the precise way I used to determine when the netmonitor is done reloading is broken.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1411889 - Record netmonitor reload time.

Review commit: https://reviewboard.mozilla.org/r/200248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200248/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8928914 [details]
Bug 1411889 - Record netmonitor reload time.

https://reviewboard.mozilla.org/r/200248/#review206370

Looks good, thanks Alex.

R+

Honza

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8928914 [details]
Bug 1411889 - Record netmonitor reload time.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200248/diff/1-2/

Comment 5

[[e-mail]]

Comment on attachment 8928914 [details]
Bug 1411889 - Record netmonitor reload time.

https://reviewboard.mozilla.org/r/200248/#review206754

::: devtools/client/netmonitor/src/connector/firefox-data-provider.js:235
(Diff revision 2)
>    getRequestFromQueue(id) {
>      return this.payloadQueue.find((item) => item.id === id);
>    }
>  
>    /**
> +   * Tells if there is still any pending request.

Add a note like `Public connector API to ...` might helpful for trace code so we know this function is used elsewhere

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8928914 [details]
Bug 1411889 - Record netmonitor reload time.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200248/diff/2-3/

Comment 7

[Alexandre Poirot [:ochameau]]

(In reply to Fred Lin [:gasolin] from comment #5)
> Add a note like `Public connector API to ...` might helpful for trace code
> so we know this function is used elsewhere

Done.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a58f74c6139
Record netmonitor reload time. r=Honza

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a58f74c6139