Closed Bug 1411906 Opened 4 years ago Closed 4 years ago

[dt-onboarding] Add close button to devtools onboarding page

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We could add a button to close the devtools onboarding page. The only obvious action today is "enable devtools". Users who triggered the shortcut by mistake have to close the tab.

Maybe we should add another button "Close this page"?
I originally wanted to have a "Don't show this again" button:
https://docs.google.com/document/d/1ku6Jn12XdTFNno0phhLjlBD2H43k5NYswALYnA_UVBA/edit#heading=h.qwcrkpgmdhth

...but now I'm waffling. Maybe that behavior would be too final? A "Close this page" sounds like a good idea for now, and we could collect telemetry on it to see if "never again" behavior is called for.

The design system has new style rules for this type of non-primary button which we should use, if we proceed with adding this button: http://design.firefox.com/photon/components/buttons.html#behaviors
It is a hard question, which is why we probably need to test this. We could add a don’t-show-again button behind a pref and see if people really dislike the dialog so much that they opt into blocking it forever.

Disabling devtools forever could even disable the last remains of it; was they ever considered? It might be interesting for ESR and enterprise users.
I think that for now I would prefer to go with Victoria's proposal in comment 1: add a "Close this page" and measure the usage. If we see that users a repeatedly opening about:devtools and closing them, we can add a don't-show-again button. It would add an extra layer of complexity, so I'd prefer to add it only if necessary.

Harald: Does that sound ok?

> Disabling devtools forever could even disable the last remains of it; was they ever considered?
> It might be interesting for ESR and enterprise users.

I don't think we ever discussed that. We are talking about removing all the entry points I guess: menu items, shortcuts, about: pages. I think that should be fairly easy.
Flags: needinfo?(hkirschner)
Decision to split disable-forever in to a separate bug for post 58.
Flags: needinfo?(hkirschner)
Blocks: 1408339
Comment on attachment 8924720 [details]
Bug 1411906 - add close button to about:devtools if devtools are disabled;

https://reviewboard.mozilla.org/r/195942/#review201348

One minor comment, but this looks good to me.

::: devtools/shim/aboutdevtools/aboutdevtools.js:75
(Diff revision 1)
>      let message = document.getElementById(id);
>      message.removeAttribute("hidden");
>    }
>  
> -  let installButton = document.getElementById("install");
> -  installButton.addEventListener("click", onInstallButtonClick);
> +  // Attach event listeners
> +  document.getElementById("install").addEventListener("click", onInstallButtonClick);

could this have a `{once: true}` option ?
I don't know how fast the Service observer picks up the change, but I guess we could have the listener fired twice here ?
Not feeling too strong about that though.
Attachment #8924720 - Flags: review?(nchevobbe) → review+
Comment on attachment 8924720 [details]
Bug 1411906 - add close button to about:devtools if devtools are disabled;

https://reviewboard.mozilla.org/r/195942/#review201348

> could this have a `{once: true}` option ?
> I don't know how fast the Service observer picks up the change, but I guess we could have the listener fired twice here ?
> Not feeling too strong about that though.

Do you mean if the user clicks twice on the button? Calling the callback one or two times should not be harmful, as we just set one preference to true. I'm going to land as is because the schedule is a bit tight :) Let's chat on IRC/slack to see if we should address this in a follow up.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f1e32b85be2
add close button to about:devtools if devtools are disabled;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/6f1e32b85be2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.