1411992 - [Activity Stream] - Remove separating line if nothing else is displayed in the Top Sites section

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, defect, P5)

Description

[Bogdan Surd, QA [:bsurd, NI]]

Steps to reproduce:
 1. Open Fennec;
 2. Remove all of the items from Top Sites;
 3. Disable Pocket and Highlights from the settings;
 4. Open any about: page;
 5. Go back to Top Sites.

Expected result:
 Top Sites is displayed with the Learn more button.

Actual result:
 There is an animation displayed for the Learn more button.

Notes:
 You can see in the video all of the variations where an animation is happening for the Learn more button, no animation is being displayed when simply opening a new tab.
 The same issue applies for a private tab.

Video: https://goo.gl/v8DwoV

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

I think this is because we shrink the height of top sites to 0 when there are no items, rather than removing it from the recyclerView (which would cause all kinds of nightmares).

I think ideally Top Sites, Top Stories, and Highlights would have their own RecyclerViews, not combined in one, which would make solving this much easier (except maybe because of the dividers).

[triage advice] Leaving in triage because I don't think it's worth fixing this:
- afaik, we're going to remove the Learn more link after some time, which will fix this issue
- It's unlikely a user will remain without any top sites for long (and if they do, that's kind of on them)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We don't uses tracking? anymore – bugs with no priority set are bugs that will be triaged.

Comment 3

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.