Upgrade Earlgrey to 1.12.1

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
RESOLVED FIXED
25 days ago
18 days ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios?)

Details

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
isabel_rios
: review+
Details | Review | Splinter Review
(Assignee)

Description

25 days ago
1.12.1 is Xcode 9 compatible.
(Assignee)

Comment 1

25 days ago
Created attachment 8922450 [details] [review]
PR Link
Attachment #8922450 - Flags: review?(irios.mozilla)
LGTM but the ClearPrivateDataTest(testClearsHistoryPanel) is failing in BB https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59f2edb1c6c5370001a6c41e#tests

It works for me locally, running the test from your branch, but not in BB, I re-run the build just in case it was a timing issue, but got same results. Do you have any idea why? 

We could land this PR to have the EarlGrey updated and open a follow up for the test or fix it here, as you prefer.
(Assignee)

Comment 3

24 days ago
Hmm, I thought upgrading earlgrey might have fixed it - what I've seen locally was that for some reason, it was making tab change to Topsite after going to History tab.  will investigate a bit more.
(Assignee)

Updated

24 days ago
Whiteboard: [needsuplift]
(Assignee)

Updated

24 days ago
Assignee: nobody → npark
(Assignee)

Updated

24 days ago
Blocks: 1410083
(Assignee)

Comment 4

24 days ago
I think using the KIFtest avoids this mystery tapping for now.  Isabel, could you take a look again?
Comment on attachment 8922450 [details] [review]
PR Link

Looks that this is working now. Thanks!
Attachment #8922450 - Flags: review?(irios.mozilla) → review+
(Assignee)

Comment 6

20 days ago
Merged: https://github.com/mozilla-mobile/firefox-ios/commit/0752259d3d4c8f63c09373f240d5f52872626e84
Status: NEW → RESOLVED
Last Resolved: 20 days ago
Resolution: --- → FIXED
Uplifted to v10.x
Whiteboard: [needsuplift]
You need to log in before you can comment on or make changes to this bug.