1.12.1 is Xcode 9 compatible.
Created attachment 8922450 [details] [review] PR Link
Attachment #8922450 - Flags: review?(irios.mozilla)
LGTM but the ClearPrivateDataTest(testClearsHistoryPanel) is failing in BB https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59f2edb1c6c5370001a6c41e#tests It works for me locally, running the test from your branch, but not in BB, I re-run the build just in case it was a timing issue, but got same results. Do you have any idea why? We could land this PR to have the EarlGrey updated and open a follow up for the test or fix it here, as you prefer.
Hmm, I thought upgrading earlgrey might have fixed it - what I've seen locally was that for some reason, it was making tab change to Topsite after going to History tab. will investigate a bit more.
I think using the KIFtest avoids this mystery tapping for now. Isabel, could you take a look again?
Comment on attachment 8922450 [details] [review] PR Link Looks that this is working now. Thanks!
Attachment #8922450 - Flags: review?(irios.mozilla) → review+
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Uplifted to v10.x
You need to log in before you can comment on or make changes to this bug.