1412071 - JSON Viewer uses unset CSS variables

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect)

Description

[Oriol Brufau [:Oriol]]

Some elements in JSON Viewer are styled with CSS variables that are never set. This shows lots of warnings when running tests, and it's so annoying.

For example, http://searchfox.org/mozilla-central/rev/dd47bee6468de7e1221b4d006342ad6b9813d0e5/devtools/client/jsonview/css/toolbar.css#23 uses

    border: var(--toolbarbutton-border);

But http://searchfox.org/mozilla-central/search?q=--toolbarbutton-border reveals that --toolbarbutton-border is not set anywhere. There are --toolbarbutton-border-color and --toolbarbutton-border-radius, but not --toolbarbutton-border.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1412071 - Use --toolbarbutton-border-color instead of removed --toolbarbutton-border.

Review commit: https://reviewboard.mozilla.org/r/193550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193550/

Comment 2

[Oriol Brufau [:Oriol]]

So this is a regression from bug 1255116, which removed --toolbarbutton-border and added --toolbarbutton-border-color. The former was `1px solid transparent`, so I used `1px solid var(--toolbarbutton-border-color)`.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8922475 [details]
Bug 1412071 - Use --toolbarbutton-border-color instead of removed --toolbarbutton-border.

https://reviewboard.mozilla.org/r/193550/#review200024

Yep, works for me.

R+

Thanks for the patch!
Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0fb92252106
Use --toolbarbutton-border-color instead of removed --toolbarbutton-border. r=Honza

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f0fb92252106