14121 - MLK: load group or docloader

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Bruce Mitchener]

When loading test #1 in viewer, a loadgroup leaks, but this may just as well be
a docloader leak.  Build from morning of September 16.

Comment 1

[Gagan]

assigining to the guru who understands this

Comment 2

[rpotts (gone)]

This is really starting to piss me off :-)

Comment 3

[rpotts (gone)]

I've found the problem...  Any page with images causes the loadgroup to leak
because of incorrect nsCOMPtr usage...

I'm building the fixes right now and will check them in as soon as they are
verified...

Comment 4

[Bruce Mitchener]

You might want to open a new bug on this one:  I checked things out a bit with
viewer on Solaris (GTK).  We create 2 docloaders during startup, then a document
bind info.  After the page loads, the document bind info object is destroyed.
During shutdown, one of the docloaders is destroyed, but not both.  If I knew
what created docloaders in viewer, I might be able to help.  I'm assuming one
for throbber and one for content?  (This was with test #0 btw.)

Comment 5

[rpotts (gone)]

The leaking loadgroups seem to be caused by the following chain:
   nsLoadGroup <-- nsImageNetContext <-- nsImageRequestImpl

It appears that this only happens when accessing http:// urls...  Why? I don't
know...  I've been deep in the imagelib for the last two days trying to figure
out what's going on.

I believe that with the changes that I've checked in so far, file:// URLs should
*not* leak load groups in the viewer...

Unfortunately, this will *only* fix the viewer.  It appears that nsXULDocument
is leaking.  This also has a reference to the LoadGroup - as well as a boat-load
of other things :-(

Comment 6

[Bruce Mitchener]

See bug #14291 for the XUL document leaking which is now fixed.

Comment 7

[rpotts (gone)]

I've made the nsILoadGroup a weak reference in the ImageNetContext...  I think
that is should also be weak in nsDocument.

This doesn't resolve the issue that ImagenetContexts are leaking - of course...
It looks like the problem there is that IL_Shutdown(...) is not being called
because the nsImageManager is *not* a service, so it has a global static
reference...

Comment 8

[rpotts (gone)]

I've made the references to the LoadGroup in nsDocument into nsWeakPtrs.  This
means that the only hard references to the LoadGroup are by the nsDocLoader and
the necko channels...

Comment 9

[Tom Everingham]

bruce, can you help us verify this bug? If you agree the resolution is correct,
please mark it as Verified. Thanks.

Comment 10

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.

Comment 11

[Tom Everingham]

old bug - marking verified