Closed Bug 1412126 Opened 2 years ago Closed 2 years ago

Remove ACTION_EXTERNAL_APPLICATIONS_AVAILABLE from StumblerManifest_services.xml

Categories

(Firefox for Android :: General, defect, P1)

Firefox 57
defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox56 --- unaffected
firefox57 + fixed
firefox58 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:

We are working with a partner and the use of ACTION_EXTERNAL_APPLICATIONS_AVAILABLE causes them to not pass the Google Compatibility Test Suite.

Based on discussions with Fennec developers, we do not believe this is not needed anymore, so quickly removing it for 57 will allow us to pass the CTS.

I'm marking this tracking 57 because that's the release we are targeting.

This would be a very low risk change, only affecting Fennec and the stumbler.
This has become a stop ship issue on the device in question.
Comment on attachment 8924141 [details]
Bug 1412126 - ACTION_EXTERNAL_APPLICATIONS_AVAILABLE no longer needed for Stumbler.

https://reviewboard.mozilla.org/r/195396/#review200460
Attachment #8924141 - Flags: review?(snorp) → review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/e5a600e0d2dc
ACTION_EXTERNAL_APPLICATIONS_AVAILABLE no longer needed for Stumbler. r=snorp
Comment on attachment 8924141 [details]
Bug 1412126 - ACTION_EXTERNAL_APPLICATIONS_AVAILABLE no longer needed for Stumbler.

Approval Request Comment
[Feature/Bug causing the regression]: Removing unnneed intent
[User impact if declined]: Will prevent us shipping on new device
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No (not really a fix)
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Non
[Is the change risky?]: No
[Why is the change risky/not risky?]: Removing code not needed anymore.
[String changes made/needed]:
Attachment #8924141 - Flags: approval-mozilla-beta?
Mike, are you intending to also land this on m-c for 58?
Assignee: nobody → mozilla
Flags: needinfo?(mozilla)
> Mike, are you intending to also land this on m-c for 58?

Yes, I've pushed it to autoland.
Flags: needinfo?(mozilla)
https://hg.mozilla.org/mozilla-central/rev/e5a600e0d2dc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8924141 [details]
Bug 1412126 - ACTION_EXTERNAL_APPLICATIONS_AVAILABLE no longer needed for Stumbler.

Beta57+
Attachment #8924141 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.