Correctly forward change sources when updating keywords

RESOLVED FIXED in Firefox 58

Status

()

Toolkit
Places
RESOLVED FIXED
29 days ago
28 days ago

People

(Reporter: kitcambridge, Assigned: kitcambridge)

Tracking

(Blocks: 1 bug)

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Currently, Sync uses the public `PlacesUtils.keywords` API; however, the new Sync bookmark buffer in bug 1305563 writes to `moz_keywords` directly, then fires `onItemChanged` observer notifications to update the cache. Forwarding the change source lets us avoid doing unnecessary work when updating synced keywords.
Comment hidden (mozreview-request)

Comment 2

28 days ago
mozreview-review
Comment on attachment 8922569 [details]
Bug 1412141 - Correctly forward change sources when updating keywords.

https://reviewboard.mozilla.org/r/193668/#review199032
Attachment #8922569 - Flags: review?(mak77) → review+

Comment 3

28 days ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98e8d4a67e67
Correctly forward change sources when updating keywords. r=mak
https://hg.mozilla.org/mozilla-central/rev/98e8d4a67e67
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.