1412142 - Expose `PlacesUtils.history.hashURL`

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Lina Cambridge (she/her) [:lina]]

Expose the Places `hash()` SQL function to JS, so that the Sync bookmark buffer in bug 1305563 can store hashed URLs for incoming bookmarks, and join with `moz_places`.

Comment 1

[Lina Cambridge (she/her) [:lina]]

Attachment: Bug 1412142 - Expose `PlacesUtils.history.hashURL`.

This patch exposes the Places `hash()` SQL function to JS.

Review commit: https://reviewboard.mozilla.org/r/193672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193672/

Comment 2

[Marco Bonardo [::mak] (Away 7-25 Aug)]

Comment on attachment 8922571 [details]
Bug 1412142 - Expose `PlacesUtils.history.hashURL`.

https://reviewboard.mozilla.org/r/193672/#review199042

::: toolkit/components/places/nsINavHistoryService.idl:1440
(Diff revision 1)
>     * Guids can be used for any places purposes (history, bookmarks, etc.)
>     * Returns null if the generation of the guid failed.
>     */
>    ACString makeGuid();
> +
> +  uint64_t hashURL(in ACString aSpec, [optional] in ACString mode);

Shouldn't it be "unsigned long long" in xpidl?

::: toolkit/components/places/nsNavHistory.cpp:3689
(Diff revision 1)
>    return NS_OK;
>  }
>  
> +NS_IMETHODIMP
> +nsNavHistory::HashURL(const nsACString& aSpec, const nsACString& aMode,
> +                      uint64_t* aHash) {

outparams should have the "_" prefix, not "a" prefix. It should be _hash or _retval

Comment 3

[Lina Cambridge (she/her) [:lina]]

Comment on attachment 8922571 [details]
Bug 1412142 - Expose `PlacesUtils.history.hashURL`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193672/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1156c45862ae
Expose `PlacesUtils.history.hashURL`. r=mak

Comment 5

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1156c45862ae