Expose `PlacesUtils.history.hashURL`

RESOLVED FIXED in Firefox 58

Status

()

Toolkit
Places
RESOLVED FIXED
29 days ago
28 days ago

People

(Reporter: kitcambridge, Assigned: kitcambridge)

Tracking

(Blocks: 1 bug)

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Expose the Places `hash()` SQL function to JS, so that the Sync bookmark buffer in bug 1305563 can store hashed URLs for incoming bookmarks, and join with `moz_places`.
Comment hidden (mozreview-request)

Comment 2

28 days ago
mozreview-review
Comment on attachment 8922571 [details]
Bug 1412142 - Expose `PlacesUtils.history.hashURL`.

https://reviewboard.mozilla.org/r/193672/#review199042

::: toolkit/components/places/nsINavHistoryService.idl:1440
(Diff revision 1)
>     * Guids can be used for any places purposes (history, bookmarks, etc.)
>     * Returns null if the generation of the guid failed.
>     */
>    ACString makeGuid();
> +
> +  uint64_t hashURL(in ACString aSpec, [optional] in ACString mode);

Shouldn't it be "unsigned long long" in xpidl?

::: toolkit/components/places/nsNavHistory.cpp:3689
(Diff revision 1)
>    return NS_OK;
>  }
>  
> +NS_IMETHODIMP
> +nsNavHistory::HashURL(const nsACString& aSpec, const nsACString& aMode,
> +                      uint64_t* aHash) {

outparams should have the "_" prefix, not "a" prefix. It should be _hash or _retval
Attachment #8922571 - Flags: review?(mak77) → review+
Comment hidden (mozreview-request)

Comment 4

28 days ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1156c45862ae
Expose `PlacesUtils.history.hashURL`. r=mak
https://hg.mozilla.org/mozilla-central/rev/1156c45862ae
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.