1412180 - [webvtt] implement region id on VTTRegion.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Benjamin Chen [:bechen]]

There is a "region id" attribute on VTTRegion.webidl we not implement yet.
https://w3c.github.io/webvtt/#webvtt-region-identifier

I need this one for our region implementation.

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1412180 - implement regionID on TextTrackRegion.

Review commit: https://reviewboard.mozilla.org/r/194478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194478/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8923300 [details]
Bug 1412180 - implement regionID on TextTrackRegion.

https://reviewboard.mozilla.org/r/194478/#review199510

Per spec the setter shouldn't throw. Throwing probably makes sense, but that needs to be defined in the spec. So, file a spec bug, link that here
and tell how likely the spec will be change.

::: dom/media/TextTrackRegion.h:138
(Diff revision 1)
> +  }
> +
> +  void SetId(const nsAString& aId, ErrorResult& aRv)
> +  {
> +    if (InvalidIdString(aId)) {
> +      aRv.Throw(NS_ERROR_DOM_INVALID_CHARACTER_ERR);

The spec doesn't define this behavior.
https://w3c.github.io/webvtt/#dom-vttregion-id

::: dom/media/TextTrackRegion.h:190
(Diff revision 1)
>    }
>  
> +  inline bool InvalidIdString(const nsAString& aId)
> +  {
> +    nsString s(aId);
> +    if(s.Find("-->") != kNotFound) {

Could you use FindInReadable here to avoid extra allocation use of nsString causes.
(or perhaps use nsAutoString)

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8923300 [details]
Bug 1412180 - implement regionID on TextTrackRegion.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194478/diff/1-2/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8923300 [details]
Bug 1412180 - implement regionID on TextTrackRegion.

https://reviewboard.mozilla.org/r/194478/#review201860

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8923300 [details]
Bug 1412180 - implement regionID on TextTrackRegion.

https://reviewboard.mozilla.org/r/194478/#review202030

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cb5c8d2f793
implement regionID on TextTrackRegion. r=rillian,smaug

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/3cb5c8d2f793