1412181 - Fix the scary way to abuse ClearOnShutdown() in MediaCache::GetMediaCache()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1411504#c9.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1412181 - add a proxy to be registered with ClearOnShutdown() to clear MediaCache::sThread.

Review commit: https://reviewboard.mozilla.org/r/194400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194400/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8923236 [details]
Bug 1412181 - add a proxy to be registered with ClearOnShutdown() to clear MediaCache::sThread.

https://reviewboard.mozilla.org/r/194400/#review199396

Thank you for making this cleaner.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd938bfa55ab
add a proxy to be registered with ClearOnShutdown() to clear MediaCache::sThread. r=gerald

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cd938bfa55ab