Closed Bug 1412187 Opened 2 years ago Closed 2 years ago

ChannelMediaResource::Resume() should call Seek() instead of CacheClientSeek()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

CacheClientSeek() will call Seek() asynchronously and should be used by MediaCache only.

ChannelMediaResource::Resume() runs on the main thread and can call Seek() directly.
Note this is a missing change from bug 1411504 P3.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8923238 - Flags: review?(gsquelart)
Comment on attachment 8923238 [details]
Bug 1412187 - ChannelMediaResource::Resume() should call Seek() instead of CacheClientSeek().

https://reviewboard.mozilla.org/r/194406/#review199398
Attachment #8923238 - Flags: review?(gsquelart) → review+
Thank you!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e9669592756
ChannelMediaResource::Resume() should call Seek() instead of CacheClientSeek(). r=gerald
https://hg.mozilla.org/mozilla-central/rev/6e9669592756
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.