Closed Bug 1412190 Opened 3 years ago Closed 3 years ago

Allow active context to be null during profiling

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
With Quantum DOM, it's sometimes true that there's no active JS context. This happens if one thread has suspended and another thread has not yet resumed. If the profile samples during this time, we get a null |cx| here and crash:
http://searchfox.org/mozilla-central/rev/40e8eb46609dcb8780764774ec550afff1eed3a5/js/src/vm/GeckoProfiler.cpp#444

This patch fixes the crash.
Attachment #8922630 - Flags: review?(jdemooij)
Priority: -- → P3
Comment on attachment 8922630 [details] [diff] [review]
patch

Review of attachment 8922630 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8922630 - Flags: review?(jdemooij) → review+
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ece293c2e9ab
Allow active context to be null during profiling (r=jandem)
https://hg.mozilla.org/mozilla-central/rev/ece293c2e9ab
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.