Allow active context to be null during profiling

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
With Quantum DOM, it's sometimes true that there's no active JS context. This happens if one thread has suspended and another thread has not yet resumed. If the profile samples during this time, we get a null |cx| here and crash:
http://searchfox.org/mozilla-central/rev/40e8eb46609dcb8780764774ec550afff1eed3a5/js/src/vm/GeckoProfiler.cpp#444

This patch fixes the crash.
Attachment #8922630 - Flags: review?(jdemooij)
Priority: -- → P3
Comment on attachment 8922630 [details] [diff] [review]
patch

Review of attachment 8922630 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8922630 - Flags: review?(jdemooij) → review+
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ece293c2e9ab
Allow active context to be null during profiling (r=jandem)
https://hg.mozilla.org/mozilla-central/rev/ece293c2e9ab
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.