Closed
Bug 1412195
Opened 7 years ago
Closed 7 years ago
Fix vsync labeling bugs
Categories
(Core :: DOM: Content Processes, enhancement, P2)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(2 files)
|
1.96 KB,
patch
|
bevis
:
review+
|
Details | Diff | Splinter Review |
|
3.73 KB,
patch
|
bevis
:
review+
|
Details | Diff | Splinter Review |
I noticed two bugs during testing. One of them is that the vsync labeling has always been broken. There's a missing QI which means that we were not actually labeling vsyncs. The other problem is that, since docshells start out in the active state, we need to treat new TabChilds as active.
Attachment #8922637 -
Flags: review?(btseng)
|
||
Updated•7 years ago
|
Attachment #8922637 -
Flags: review?(btseng) → review+
|
Assignee | |
Comment 1•7 years ago
|
||
Pushing this to try exposed a bug where a caller was using nsDocShell::SetIsActive directly in the child process. Consequently, we were missing the change in the active state, so sActiveTabs was wrong. The caller is this one: http://searchfox.org/mozilla-central/rev/21363323fd4aa21db074c808fb5358a46df6d698/toolkit/components/thumbnails/content/backgroundPageThumbsContent.js#172
Attachment #8923027 -
Flags: review?(btseng)
|
|
||
Updated•7 years ago
|
Attachment #8923027 -
Flags: review?(btseng) → review+
|
||
Updated•7 years ago
|
Priority: -- → P2
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8519a2b6dc Track all changes to TabChild active state (r=bevis)
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d8519a2b6dc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•