1412212 - Some more tweaks to MediaDecoder::DumpDebugInfo()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1412212. P1 - the DUMP() macro needs no nsPrintfCString.

printf_stderr() already supports string formatting.

Review commit: https://reviewboard.mozilla.org/r/193800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193800/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1412212. P2 - compact the output of GetDebugInfo().

Review commit: https://reviewboard.mozilla.org/r/193802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193802/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1412212. P3 - also dump debug info of AudioSink.

Review commit: https://reviewboard.mozilla.org/r/193804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193804/

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8922674 [details]
Bug 1412212. P1 - the DUMP() macro needs no nsPrintfCString.

https://reviewboard.mozilla.org/r/193800/#review198918

Comment 5

[James Cheng[:JamesCheng]]

Comment on attachment 8922675 [details]
Bug 1412212. P2 - compact the output of GetDebugInfo().

https://reviewboard.mozilla.org/r/193802/#review198920

Comment 6

[James Cheng[:JamesCheng]]

Comment on attachment 8922676 [details]
Bug 1412212. P3 - also dump debug info of AudioSink.

https://reviewboard.mozilla.org/r/193804/#review198924

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61d60f1e1333
P1 - the DUMP() macro needs no nsPrintfCString. r=JamesCheng
https://hg.mozilla.org/integration/autoland/rev/317c1de43ab6
P2 - compact the output of GetDebugInfo(). r=JamesCheng
https://hg.mozilla.org/integration/autoland/rev/be73e9c02c4b
P3 - also dump debug info of AudioSink. r=JamesCheng

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/61d60f1e1333
https://hg.mozilla.org/mozilla-central/rev/317c1de43ab6
https://hg.mozilla.org/mozilla-central/rev/be73e9c02c4b