1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 57.0b12 build2 (20171026211016)
- 58.0a1 (2017-10-26) 

[Affected platforms]:
- Windows 7 x64

[Steps to reproduce]:
1. Launch Firefox 
2. Dismiss all the Top Stories and Highlights tiles
3. Inspect the informative messages from each section

[Expected result]:
- The user friendly messages are properly displayed

[Actual result]:
- Font issues can be noticed: some letters are smaller (e.g. "t") or bigger (e.g. "p") than the others - see the screenshot https://goo.gl/pkT6aX

Comment 1

[Tim Spurway [:tspurway]]

Too late in the cycle to fix.  The text is still legible.

Comment 2

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3813 to be uplifted via bug 1415812.

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93

Comment 4

[Ciprian Muresan [:cmuresan], Ecosystem QA; PTO Until the 7th of June, please ping @poiegas]

User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

I have verified that the issue is no longer reproducible on the latest Nightly 59.0a1 (Build ID: 20171121100129) using Windows 7.

Comment 5

[Gerry Chang [:gchang]]

Bug 1415812 has been uplifted to 58. We should not mark 58 fixed.

Comment 6

[Ed Lee :Mardak]

Not entirely sure what caused that status change, but looks like the last several changes were unintended. Just to confirm, this should be 57-wontfix, 58-affected, 59-verified.

Comment 7

[Gerry Chang [:gchang]]

Sorry for typo in comment #5. What I meant is bug 1415812 has not been uplifted to 58.

Comment 8

[Ed Lee :Mardak]

gchang says this bug has missed 58.0b8. It doesn't have a patch with beta approval flag. Please attach the appropriate patch without install.rdf.in changes and request approval ASAP.

Comment 9

[Andrei Oprea [:andreio]]

Attachment: Bug 1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections.

Review commit: https://reviewboard.mozilla.org/r/204302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204302/

Comment 10

[Andrei Oprea [:andreio]]

Comment on attachment 8933379 [details]
Bug 1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections.

Approval Request Comment
[Feature/Bug causing the regression]: https://github.com/piatra/activity-stream/commit/9a4d144881a79a0d6851869ff8357dbab6f8e4ab
[User impact if declined]: hard to read text on activity stream page on windows 7
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: 
[Is the change risky?]: no
[Why is the change risky/not risky?]: only small css change
[String changes made/needed]:

Comment 11

[Ursula Sarracini (:ursula)]

Comment on attachment 8933379 [details]
Bug 1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections.

https://reviewboard.mozilla.org/r/204302/#review209876

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8933379 [details]
Bug 1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections.

Fix a font issue. Beta58+.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a5ffba3f3461