1412274 - [compare-locales] update to flake8 3.5.0

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Description

[Axel Hecht [:Pike]]

Version 3.5.0 of flake8 got released, and it's adding some more checks, notably bare excepts and ambiguous variable names, both of which show up in compare-locales.

Two things:

We should look at those checks, and see if they're good for us or not.
We should tie the version of flake8 in tox.ini, probably to <3.6.0. That seems to be the right way to keep our tests from suddenly failing.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1412274, update compare-locales to latest flake8 test,

Also locking flake8 in tox to 3.5 and later, but not 3.6.

Review commit: https://reviewboard.mozilla.org/r/194004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194004/

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8922866 [details]
bug 1412274, update compare-locales to latest flake8 test,

https://reviewboard.mozilla.org/r/194004/#review199102

::: compare_locales/paths.py:138
(Diff revision 1)
>          assert not self.rules
>  
>          def filter_(module, path, entity=None):
>              try:
>                  rv = filter(module, path, entity=entity)
> -            except:
> +            except:  # noqa, we really want to handle EVERYTHING here

I think you could also catch all errors by specifying BaseException which is the base class for all system errors and for Exception.

    except BaseException:
        …

::: compare_locales/paths.py:557
(Diff revision 1)
>          Only works with synchronous loads, used by compare-locales, which
>          is local anyway.
>          '''
>          filter_path = mozpath.join(mozpath.dirname(self.inipath), 'filter.py')
>          try:
> -            l = {}
> +            local = {}

<3

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8922866 [details]
bug 1412274, update compare-locales to latest flake8 test,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194004/diff/1-2/

Comment 4

[Axel Hecht [:Pike]]

FIXED, https://hg.mozilla.org/l10n/compare-locales/rev/e582b5534b02f6ad69b11c8ba7c4708ec72610fe.