1412281 - No longer possible to set a custom timerange in super search

Status: VERIFIED FIXED

(Socorro :: General, defect, P1)

Description

[[:philipp]]

today i noticed that i cannot set an arbitrary date_to-value in the date/time-picker in super search anymore which is probably a recent regression.

str:
- visit https://crash-stats.mozilla.com/search/
- set "from"-date back to october 1
- it's not possible to set the "to"-date to something further back than 7 days ago...

it's also not possible to change the date-range through the parameters in the url. when i try with https://crash-stats.mozilla.com/search/?date=>%3D2017-10-01T14%3A31%3A00.000Z&date=<2017-10-05T16%3A31%3A40.000Z the only output i see is "Run a search to get some results".

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I've never worked on this part of Super Search, so I don't know what the intended behavior should be, but that seems curious to me.

I wonder if this is related to switching to npm-installed libs. That's something we pushed out this week. I'll test that theory out now.

Making this a P1.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I went back to before we changed to npm-installed libs and the "to" field in the UI works fine. So I think the problem was either introduced by switching to npm-installed libs or some other change between then and now.

To test, I went back to 6fb19b7b5bd5ceb92b8e97a82399926c0f22c03f and cherry-picked f42f2e2cf99b688d46e0c2bd7ddb3538e4058d71 so that I could do "make dockerbuild" with the right version of breakpad.

Mike: Can you look into this? This would be important to fix and push out today if we can.

Comment 3

[Osmose [:osmose, :mkelly]]

Attachment: pr 4064: Fix bug 1412281: Update how we configure flatpickr.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/e439e64de909b636e8ae409ea7912e21d35da1d0
Fix bug 1412281: Update how we configure flatpickr.

Flatpickr now returns a list of selected dates instead of a single date object,
so the onChange callbacks have been updated to unpack the list being returned.
The callbacks themselves were also moved to the initial config object, although
this isn't strictly necessary.

The .eslintrc config was also updated to support the object function shorthand
being used in this patch.

https://github.com/mozilla-services/socorro/commit/0482d7db5ae7d3928409cc83e9bcdeafae23f41c
Merge pull request #4064 from Osmose/date-picker

Fix bug 1412281: Update how we configure flatpickr.

Comment 5

[Osmose [:osmose, :mkelly]]

This has been deployed to production, and philipp confirmed via IRC that the date pickers are working properly again.