1412282 - Allow calling Assert.jsm methods directly from other test-only modules

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[:Paolo Amadini]

We use test-only modules to share utilities that are specific to an area of the code and make them available to all the tests in the tree.

In order to use assertions from these modules, we have to pass the current Assert.jsm scope to them explicitly. However, we don't use multiple instances in practice because the scope is always the one for the currently running test, and the test-only modules share this globally anyways. We also never run tests in parallel in the same process because this would run into a number of other issues, tests are parallelized using multiple processes.

We can do a minimal change to make the Assert.jsm scope a per-process global, available just by importing the module. To minimize changes, we can make the constructor also return the global instance.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1412282 - Allow calling Assert.jsm methods directly from other test-only modules.

This adds a global instance that can be used by invoking assertion methods directly on the imported Assert object. The test suites set the global reporter function to the one for the currently running test.

Review commit: https://reviewboard.mozilla.org/r/193954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193954/

Comment 2

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=697238eac76c08a25ba5632873ad1cdd9bb98a8a

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8922803 [details]
Bug 1412282 - Allow calling Assert.jsm methods directly from other test-only modules.

https://reviewboard.mozilla.org/r/193954/#review199558

Cool, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90b950f6e65b
Allow calling Assert.jsm methods directly from other test-only modules. r=mikedeboer

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/90b950f6e65b

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/90b950f6e65b