Closed Bug 1412290 Opened 3 years ago Closed 3 years ago

Port bug 1409533 - Require rust 1.21.0

Categories

(Thunderbird :: Build Config, enhancement)

enhancement
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file, 2 obsolete files)

For the update to rust 1.20.0 I landed this
https://hg.mozilla.org/comm-central/rev/5e346bc9fee657ba01309c1cd3d11ec97ef0ddb3
but now I don't know where to get the new numbers from.
Flags: needinfo?(mozilla)
Ted and Ralph: Where do we get version, size and digest from?
Flags: needinfo?(ted)
Flags: needinfo?(giles)
Actually, wrong changeset, that was for suite, I landed this:
https://hg.mozilla.org/comm-central/rev/7be864a6cef76ee4da1264c0430f9d02050cb97f
Depends on: 1412352
I've asked for the appropriate files to be uploaded to tooltool.
Flags: needinfo?(ted)
Flags: needinfo?(mozilla)
Flags: needinfo?(giles)
And what about updating the C-C tooltool manifests?
We can't update the manifests until the files have actually been uploaded to tooltool.
I've downloaded the linux64 package and I get:
  {
    "version": "rustc 1.21.0 (3b72af97e 2017-10-09) repack",
    "size": 164183024,
    "digest": "0f2451ac1382efe581c42c97d933aabb639bb13d9e75f0f71e241e04d0aa92fced133cff3c458c1f071d540ceac9a8c526dd1bab1d0de14bfe19fa77710941d4",
    "algorithm": "sha512",
    "filename": "rustc.tar.xz",
    "unpack": true
  }

Quite a complicated process for lin32+64, macosx64 and Win32+64 :-(
Attached patch 1412290-rust.patch (obsolete) — Splinter Review
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8922975 - Flags: review?(mozilla)
Comment on attachment 8922975 [details] [diff] [review]
1412290-rust.patch

Review of attachment 8922975 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/config/tooltool-manifests/linux64/releng.manifest
@@ +20,1 @@
>      "size": 166736820,

This needs to be updated.

::: mail/config/tooltool-manifests/win64/releng.manifest
@@ +5,5 @@
>      "algorithm": "sha512",
>      "filename": "mozmake.exe"
>    },
>    {
>      "version": "rustc 1.20.0 (f3d6973f4 2017-08-27) repack",

The version should be updated here.
Attachment #8922975 - Flags: review?(mozilla) → review-
Attached patch 1412290-rust.patch (v2) (obsolete) — Splinter Review
I guess it's r+ with the (missing) copy/paste errors fixed ;-)
Attachment #8922975 - Attachment is obsolete: true
Attachment #8922985 - Flags: review+
Comment on attachment 8922985 [details] [diff] [review]
1412290-rust.patch (v2)

Review of attachment 8922985 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/config/tooltool-manifests/linux64/releng.manifest
@@ +17,5 @@
>    },
>    {
> +    "version": "rustc 1.21.0 (3b72af97e 2017-10-09) repack",
> +    "size": 164183024,
> +    "164183024": "0f2451ac1382efe581c42c97d933aabb639bb13d9e75f0f71e241e04d0aa92fced133cff3c458c1f071d540ceac9a8c526dd1bab1d0de14bfe19fa77710941d4",

This should be digest.
Attachment #8922985 - Flags: review+ → review-
Third time lucky ;-(
Attachment #8922985 - Attachment is obsolete: true
Attachment #8922990 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/98161291e20d
Port bug 1409533 - Require rust 1.21.0 - Rust details from bug 1412352. r=tomprince
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
Jorg, for future versions of this bug, you might find my script at https://github.com/rillian/rust-build/blob/master/splat_rust.py helpful. It copies manifest.tt into hardcoded tooltool manifest files.
You need to log in before you can comment on or make changes to this bug.