Closed
Bug 1412290
Opened 7 years ago
Closed 7 years ago
Port bug 1409533 - Require rust 1.21.0
Categories
(Thunderbird :: Build Config, enhancement)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 58.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file, 2 obsolete files)
6.14 KB,
patch
|
tomprince
:
review+
|
Details | Diff | Splinter Review |
For the update to rust 1.20.0 I landed this https://hg.mozilla.org/comm-central/rev/5e346bc9fee657ba01309c1cd3d11ec97ef0ddb3 but now I don't know where to get the new numbers from.
Flags: needinfo?(mozilla)
Assignee | ||
Comment 1•7 years ago
|
||
Ted and Ralph: Where do we get version, size and digest from?
Flags: needinfo?(ted)
Flags: needinfo?(giles)
Assignee | ||
Comment 2•7 years ago
|
||
Actually, wrong changeset, that was for suite, I landed this: https://hg.mozilla.org/comm-central/rev/7be864a6cef76ee4da1264c0430f9d02050cb97f
Comment 3•7 years ago
|
||
I've asked for the appropriate files to be uploaded to tooltool.
Flags: needinfo?(ted)
Flags: needinfo?(mozilla)
Flags: needinfo?(giles)
Assignee | ||
Comment 4•7 years ago
|
||
And what about updating the C-C tooltool manifests?
Comment 5•7 years ago
|
||
We can't update the manifests until the files have actually been uploaded to tooltool.
Assignee | ||
Comment 6•7 years ago
|
||
I've downloaded the linux64 package and I get: { "version": "rustc 1.21.0 (3b72af97e 2017-10-09) repack", "size": 164183024, "digest": "0f2451ac1382efe581c42c97d933aabb639bb13d9e75f0f71e241e04d0aa92fced133cff3c458c1f071d540ceac9a8c526dd1bab1d0de14bfe19fa77710941d4", "algorithm": "sha512", "filename": "rustc.tar.xz", "unpack": true } Quite a complicated process for lin32+64, macosx64 and Win32+64 :-(
Assignee | ||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Comment on attachment 8922975 [details] [diff] [review] 1412290-rust.patch Review of attachment 8922975 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/config/tooltool-manifests/linux64/releng.manifest @@ +20,1 @@ > "size": 166736820, This needs to be updated. ::: mail/config/tooltool-manifests/win64/releng.manifest @@ +5,5 @@ > "algorithm": "sha512", > "filename": "mozmake.exe" > }, > { > "version": "rustc 1.20.0 (f3d6973f4 2017-08-27) repack", The version should be updated here.
Attachment #8922975 -
Flags: review?(mozilla) → review-
Assignee | ||
Comment 9•7 years ago
|
||
I guess it's r+ with the (missing) copy/paste errors fixed ;-)
Attachment #8922975 -
Attachment is obsolete: true
Attachment #8922985 -
Flags: review+
Comment 10•7 years ago
|
||
Comment on attachment 8922985 [details] [diff] [review] 1412290-rust.patch (v2) Review of attachment 8922985 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/config/tooltool-manifests/linux64/releng.manifest @@ +17,5 @@ > }, > { > + "version": "rustc 1.21.0 (3b72af97e 2017-10-09) repack", > + "size": 164183024, > + "164183024": "0f2451ac1382efe581c42c97d933aabb639bb13d9e75f0f71e241e04d0aa92fced133cff3c458c1f071d540ceac9a8c526dd1bab1d0de14bfe19fa77710941d4", This should be digest.
Attachment #8922985 -
Flags: review+ → review-
Assignee | ||
Comment 11•7 years ago
|
||
Third time lucky ;-(
Attachment #8922985 -
Attachment is obsolete: true
Updated•7 years ago
|
Attachment #8922990 -
Flags: review+
Comment 12•7 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/98161291e20d Port bug 1409533 - Require rust 1.21.0 - Rust details from bug 1412352. r=tomprince
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 58.0
Comment 13•7 years ago
|
||
Jorg, for future versions of this bug, you might find my script at https://github.com/rillian/rust-build/blob/master/splat_rust.py helpful. It copies manifest.tt into hardcoded tooltool manifest files.
You need to log in
before you can comment on or make changes to this bug.
Description
•