Unlocalized strings in the menu

RESOLVED FIXED

Status

()

Firefox for iOS
General
P1
blocker
RESOLVED FIXED
28 days ago
24 days ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.0)

Details

Attachments

(1 attachment)

(Assignee)

Description

28 days ago
First four items and the bottom "Settings" item:

   https://wopr.norad.org/~fxios/screenshots/fxios/v10/de/de/iPhone%20SE-03MenuOnTopSites-01.png

Did we forget to make those localizable or is something else happening?
(Assignee)

Updated

28 days ago
Severity: normal → blocker

Updated

28 days ago
Assignee: nobody → gkeeley
Created attachment 8922868 [details]
Page action menu.PNG

Same for the page action menu

Comment 2

28 days ago
Pseudo-localization works fine, we also have a unique string for "Reading List" in Strings.swift:

 `public static let AppMenuReadingListTitleString = NSLocalizedString("Menu.OpenReadingListAction.AccessibilityLabel", tableName: "Menu", value: "Reading List", comment: "Accessibility label for the button, displayed in the menu, used to open the Reading list home panel.")`

I am currently stumped.

Comment 3

28 days ago
We also have this "Reading List" string declared in HomePanels.swift:
```
HomePanelDescriptor(
            makeViewController: { profile in
                let controller = ReadingListPanel()
                controller.profile = profile
                return controller
            },
            imageName: "ReadingList",
            accessibilityLabel: NSLocalizedString("Reading list", comment: "Panel accessibility label"),
            accessibilityIdentifier: "HomePanels.ReadingList"),
        ]
```

Comment 4

28 days ago
Comment 3 usage would be for the panel itself though and not the menu item, and would have no bearing on the bug.
There are two "reading list" in the XLIFF file, the one with "Reading List" (uppercase L) has a proper identifier https://github.com/mozilla-l10n/firefoxios-l10n/blob/master/en-US/firefox-ios.xliff#L3064

Comment 6

28 days ago
St3fan is figuring this one out, quote:

"
table used to be `Client/Menu.strings` but now it is `Shared/Supporting Files/Menu.strings`

See
```# Because Xcode is unpredictable. See bug 1162510 - Sync.strings are not imported
FILENAME_OVERRIDES = {
    "Shared/Supporting Files/Info.plist": "Shared/Localizable.strings",
    "Shared/Supporting Files/Shared.strings": "Client/Shared.strings",
    "Storage.strings": "Client/Storage.strings",
}```
"
Assignee: gkeeley → sarentz
(Assignee)

Updated

24 days ago
Status: NEW → RESOLVED
Last Resolved: 24 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.