Don't invoke client.mk from outside `mach`

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

2 years ago
client.mk has been pseudo-deprecated as an interface to the build system for years.

While `mach` may invoke client.mk under the hood, the preferred interface for everyone else is `mach`.

Let's fix the few stragglers in the repo still using client.mk directly.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Blocks: 1412398
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

2 years ago
mozreview-review
Comment on attachment 8922892 [details]
Bug 1412356 - Don't invoke client.mk from mobile l10n automation;

https://reviewboard.mozilla.org/r/194056/#review200622
Attachment #8922892 - Flags: review+

Comment 12

2 years ago
mozreview-review
Comment on attachment 8922893 [details]
Bug 1412356 - Invoke `mach build` for multi locale builds;

https://reviewboard.mozilla.org/r/194058/#review200624
Attachment #8922893 - Flags: review+
Attachment #8922892 - Flags: review?(core-build-config-reviews)
Attachment #8922893 - Flags: review?(core-build-config-reviews)

Comment 13

2 years ago
mozreview-review
Comment on attachment 8922894 [details]
Bug 1412356 - Don't invoke client.mk from root analysis builds;

https://reviewboard.mozilla.org/r/194060/#review200648

I can't tell if ANALYZED_OBJDIR is relevant here (the difference between a browser and shell build, perhaps). Maybe sfink can confirm.
Attachment #8922894 - Flags: review?(core-build-config-reviews) → review?(sphink)

Comment 14

2 years ago
mozreview-review
Comment on attachment 8922895 [details]
Bug 1412356 - Update docs on PGO builds to not reference client.mk;

https://reviewboard.mozilla.org/r/194062/#review200654
Attachment #8922895 - Flags: review+
Attachment #8922895 - Flags: review?(core-build-config-reviews)
Attachment #8922896 - Flags: review?(core-build-config-reviews) → review?(cmanchester)

Comment 15

2 years ago
mozreview-review
Comment on attachment 8922896 [details]
Bug 1412356 - Update CLOBBER message to not recommend client.mk;

https://reviewboard.mozilla.org/r/194064/#review200656
Attachment #8922896 - Flags: review?(cmanchester) → review+

Comment 16

2 years ago
mozreview-review
Comment on attachment 8922894 [details]
Bug 1412356 - Don't invoke client.mk from root analysis builds;

https://reviewboard.mozilla.org/r/194060/#review200704

Oops. Have an r+. This is one of those things that I didn't purge because an esr was still using them. But that's way way in the past now. This file is unused, along with all the other mozharness-based hazard analysis build goop.
Attachment #8922894 - Flags: review?(sphink) → review+

Comment 17

2 years ago
mozreview-review
Comment on attachment 8922894 [details]
Bug 1412356 - Don't invoke client.mk from root analysis builds;

https://reviewboard.mozilla.org/r/194060/#review200710

Filed bug 1413687 for removing all of it.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 23

2 years ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b2e91dc30b0
Don't invoke client.mk from mobile l10n automation; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/c6f61e994667
Invoke `mach build` for multi locale builds; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/e03916280010
Don't invoke client.mk from root analysis builds; r=sfink
https://hg.mozilla.org/integration/autoland/rev/4d556839698e
Update docs on PGO builds to not reference client.mk; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/8f0a243a8334
Update CLOBBER message to not recommend client.mk; r=chmanchester
Attachment #8922892 - Flags: review?(core-build-config-reviews)
Attachment #8922894 - Flags: review?(core-build-config-reviews)
Attachment #8922895 - Flags: review?(core-build-config-reviews)
Attachment #8922896 - Flags: review?(core-build-config-reviews)
Attachment #8922893 - Flags: review?(core-build-config-reviews)

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.