Closed
Bug 1412356
Opened 7 years ago
Closed 7 years ago
Don't invoke client.mk from outside `mach`
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
client.mk has been pseudo-deprecated as an interface to the build system for years. While `mach` may invoke client.mk under the hood, the preferred interface for everyone else is `mach`. Let's fix the few stragglers in the repo still using client.mk directly.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8922892 [details] Bug 1412356 - Don't invoke client.mk from mobile l10n automation; https://reviewboard.mozilla.org/r/194056/#review200622
Attachment #8922892 -
Flags: review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8922893 [details] Bug 1412356 - Invoke `mach build` for multi locale builds; https://reviewboard.mozilla.org/r/194058/#review200624
Attachment #8922893 -
Flags: review+
Updated•7 years ago
|
Attachment #8922892 -
Flags: review?(core-build-config-reviews)
Attachment #8922893 -
Flags: review?(core-build-config-reviews)
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8922894 [details] Bug 1412356 - Don't invoke client.mk from root analysis builds; https://reviewboard.mozilla.org/r/194060/#review200648 I can't tell if ANALYZED_OBJDIR is relevant here (the difference between a browser and shell build, perhaps). Maybe sfink can confirm.
Updated•7 years ago
|
Attachment #8922894 -
Flags: review?(core-build-config-reviews) → review?(sphink)
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8922895 [details] Bug 1412356 - Update docs on PGO builds to not reference client.mk; https://reviewboard.mozilla.org/r/194062/#review200654
Attachment #8922895 -
Flags: review+
Updated•7 years ago
|
Attachment #8922895 -
Flags: review?(core-build-config-reviews)
Attachment #8922896 -
Flags: review?(core-build-config-reviews) → review?(cmanchester)
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8922896 [details] Bug 1412356 - Update CLOBBER message to not recommend client.mk; https://reviewboard.mozilla.org/r/194064/#review200656
Attachment #8922896 -
Flags: review?(cmanchester) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8922894 [details] Bug 1412356 - Don't invoke client.mk from root analysis builds; https://reviewboard.mozilla.org/r/194060/#review200704 Oops. Have an r+. This is one of those things that I didn't purge because an esr was still using them. But that's way way in the past now. This file is unused, along with all the other mozharness-based hazard analysis build goop.
Attachment #8922894 -
Flags: review?(sphink) → review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8922894 [details] Bug 1412356 - Don't invoke client.mk from root analysis builds; https://reviewboard.mozilla.org/r/194060/#review200710 Filed bug 1413687 for removing all of it.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 23•7 years ago
|
||
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b2e91dc30b0 Don't invoke client.mk from mobile l10n automation; r=chmanchester https://hg.mozilla.org/integration/autoland/rev/c6f61e994667 Invoke `mach build` for multi locale builds; r=chmanchester https://hg.mozilla.org/integration/autoland/rev/e03916280010 Don't invoke client.mk from root analysis builds; r=sfink https://hg.mozilla.org/integration/autoland/rev/4d556839698e Update docs on PGO builds to not reference client.mk; r=chmanchester https://hg.mozilla.org/integration/autoland/rev/8f0a243a8334 Update CLOBBER message to not recommend client.mk; r=chmanchester
Comment 24•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b2e91dc30b0 https://hg.mozilla.org/mozilla-central/rev/c6f61e994667 https://hg.mozilla.org/mozilla-central/rev/e03916280010 https://hg.mozilla.org/mozilla-central/rev/4d556839698e https://hg.mozilla.org/mozilla-central/rev/8f0a243a8334
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Attachment #8922892 -
Flags: review?(core-build-config-reviews)
Updated•7 years ago
|
Attachment #8922894 -
Flags: review?(core-build-config-reviews)
Updated•7 years ago
|
Attachment #8922895 -
Flags: review?(core-build-config-reviews)
Updated•7 years ago
|
Attachment #8922896 -
Flags: review?(core-build-config-reviews)
Updated•7 years ago
|
Attachment #8922893 -
Flags: review?(core-build-config-reviews)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•