Remove checkbox-baseline and checkbox-radio xbl bindings

RESOLVED FIXED in Firefox 58

Status

()

Toolkit
Themes
P3
normal
RESOLVED FIXED
26 days ago
18 days ago

People

(Reporter: bgrins, Assigned: mossop)

Tracking

(Blocks: 1 bug)

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

(Whiteboard: [xbl-remove-unused])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

26 days ago
"checkbox-baseline" is never directly used for desktop - it holds the implementation for "checkbox", and all "checkbox" does is include a stylesheet.  We could move the implementation directly into "checkbox".

The other reference is in android which uses it to implement a binding called "checkbox-radio", which itself never appears to be used: https://dxr.mozilla.org/mozilla-central/search?q=path%3Aandroid+checkbox.xml

AFAICT we can remove both of these bindings
(In reply to Brian Grinstead [:bgrins] from comment #0)
> "checkbox-baseline" is never directly used for desktop - it holds the
> implementation for "checkbox", and all "checkbox" does is include a
> stylesheet.  We could move the implementation directly into "checkbox".
> 
> The other reference is in android which uses it to implement a binding
> called "checkbox-radio", which itself never appears to be used:
> https://dxr.mozilla.org/mozilla-central/search?q=path%3Aandroid+checkbox.xml

This was added in Bug 485381 (!), which predates Native Fennec by a long way.  Burn it with fire!

Updated

21 days ago
status-firefox57: --- → wontfix
Priority: -- → P3
(Assignee)

Updated

20 days ago
Assignee: nobody → dtownsend
Comment hidden (mozreview-request)
(Reporter)

Updated

20 days ago
Whiteboard: [xbl-remove-unused]
Comment hidden (mozreview-request)
(Assignee)

Updated

19 days ago
Attachment #8924650 - Flags: review?(nalexander)
Comment on attachment 8924650 [details]
Bug 1412361: Remove unused XBL checkbox-baseline and checkbox-radio.

https://reviewboard.mozilla.org/r/195886/#review201574

This makes sense to me!

::: mobile/android/chrome/content/bindings/checkbox.xml:12
(Diff revision 2)
> -        </body>
> -      </method>
> -    </implementation>
> -  </binding>
> -
>    <binding id="checkbox-with-spacing"

As discussed on IRC, it looks like this can go too, and with it all the `<checkbox>` styling in `m/a/chrome/content/aboutAddons.css`.  Your choice if that's a part 2 on this ticket or a follow-up ticket.
Attachment #8924650 - Flags: review?(nalexander) → review+
(Assignee)

Comment 5

19 days ago
mozreview-review-reply
Comment on attachment 8924650 [details]
Bug 1412361: Remove unused XBL checkbox-baseline and checkbox-radio.

https://reviewboard.mozilla.org/r/195886/#review201574

> As discussed on IRC, it looks like this can go too, and with it all the `<checkbox>` styling in `m/a/chrome/content/aboutAddons.css`.  Your choice if that's a part 2 on this ticket or a follow-up ticket.

I'm going to take care of this in bug 1414406

Comment 6

19 days ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31b3ba0e8491
Remove unused XBL checkbox-baseline and checkbox-radio. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/31b3ba0e8491
Status: NEW → RESOLVED
Last Resolved: 18 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

18 days ago
Blocks: 1414521
You need to log in before you can comment on or make changes to this bug.