1412361 - Remove checkbox-baseline and checkbox-radio xbl bindings

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P3)

Description

[Brian Grinstead [:bgrins]]

"checkbox-baseline" is never directly used for desktop - it holds the implementation for "checkbox", and all "checkbox" does is include a stylesheet.  We could move the implementation directly into "checkbox".

The other reference is in android which uses it to implement a binding called "checkbox-radio", which itself never appears to be used: https://dxr.mozilla.org/mozilla-central/search?q=path%3Aandroid+checkbox.xml

AFAICT we can remove both of these bindings

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Brian Grinstead [:bgrins] from comment #0)
> "checkbox-baseline" is never directly used for desktop - it holds the
> implementation for "checkbox", and all "checkbox" does is include a
> stylesheet.  We could move the implementation directly into "checkbox".
> 
> The other reference is in android which uses it to implement a binding
> called "checkbox-radio", which itself never appears to be used:
> https://dxr.mozilla.org/mozilla-central/search?q=path%3Aandroid+checkbox.xml

This was added in Bug 485381 (!), which predates Native Fennec by a long way.  Burn it with fire!

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1412361: Remove unused XBL checkbox-baseline and checkbox-radio.

Review commit: https://reviewboard.mozilla.org/r/195886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195886/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8924650 [details]
Bug 1412361: Remove unused XBL checkbox-baseline and checkbox-radio.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195886/diff/1-2/

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8924650 [details]
Bug 1412361: Remove unused XBL checkbox-baseline and checkbox-radio.

https://reviewboard.mozilla.org/r/195886/#review201574

This makes sense to me!

::: mobile/android/chrome/content/bindings/checkbox.xml:12
(Diff revision 2)
> -        </body>
> -      </method>
> -    </implementation>
> -  </binding>
> -
>    <binding id="checkbox-with-spacing"

As discussed on IRC, it looks like this can go too, and with it all the `<checkbox>` styling in `m/a/chrome/content/aboutAddons.css`.  Your choice if that's a part 2 on this ticket or a follow-up ticket.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8924650 [details]
Bug 1412361: Remove unused XBL checkbox-baseline and checkbox-radio.

https://reviewboard.mozilla.org/r/195886/#review201574

> As discussed on IRC, it looks like this can go too, and with it all the `<checkbox>` styling in `m/a/chrome/content/aboutAddons.css`.  Your choice if that's a part 2 on this ticket or a follow-up ticket.

I'm going to take care of this in bug 1414406

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b3ba0e8491
Remove unused XBL checkbox-baseline and checkbox-radio. r=nalexander

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/31b3ba0e8491