1412388 - Remove talos pageloader-signed.xpi

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Robert Wood [:rwood]]

As/of Bug 1402426 we no longer need to provide and sign an XPI for the talos add-ons. Remove the talos add-on pageloader-signed.xpi.

Comment 1

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=850ce563d31d408d68d7c25a669599290497a955

Comment 2

[Robert Wood [:rwood]]

Attachment: Bug 1412388 - Remove talos pageloader-signed.xpi;

Review commit: https://reviewboard.mozilla.org/r/201780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201780/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8930651 [details]
Bug 1412388 - Remove talos pageloader-signed.xpi;

https://reviewboard.mozilla.org/r/201780/#review207116

oh cool!

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 44df418a2637 -d d9bbfb2a7e42: rebasing 435232:44df418a2637 "Bug 1412388 - Remove talos pageloader-signed.xpi; r=jmaher" (tip)
tool internal:merge can't handle binary
local [dest] changed testing/talos/talos/pageloader/pageloader-signed.xpi which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8930651 [details]
Bug 1412388 - Remove talos pageloader-signed.xpi;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201780/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1182ae0e001b
Remove talos pageloader-signed.xpi; r=jmaher

Comment 7

[Ionuț Goldan [:igoldan]]

I've made my changes out of mozilla-central, which still had the pageloader-signed.xpi file.
I'm rebasing this onto autoland, then push again.

Comment 8

[Robert Wood [:rwood]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #7)
> I've made my changes out of mozilla-central, which still had the
> pageloader-signed.xpi file.
> I'm rebasing this onto autoland, then push again.

Not sure what you mean here, this patch has already landed. If you are rebasing a local patch of yours (in a different bug) no need to add a comment to this bug (perhaps you meant to add this comment to a different bug?)

Comment 9

[Ionuț Goldan [:igoldan]]

(In reply to Robert Wood [:rwood] from comment #8)
> (In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #7)
> > I've made my changes out of mozilla-central, which still had the
> > pageloader-signed.xpi file.
> > I'm rebasing this onto autoland, then push again.
> 
> Not sure what you mean here, this patch has already landed. If you are
> rebasing a local patch of yours (in a different bug) no need to add a
> comment to this bug (perhaps you meant to add this comment to a different
> bug?)

My comment wasn't correct, actually. I only read comment 4, and thought I had to update my push.

Comment 10

[Robert Wood [:rwood]]

Ah, comment 4 just meant I tried to land this patch but it couldn't merge because of a conflict - I had to pull the latest, rebase my patch (resolve the conflict), and land it again. :)

Comment 11

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/1182ae0e001b