Closed
Bug 1412388
Opened 5 years ago
Closed 5 years ago
Remove talos pageloader-signed.xpi
Categories
(Testing :: Talos, enhancement)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: rwood, Assigned: rwood)
References
Details
(Whiteboard: [PI:November] )
Attachments
(1 file)
As/of Bug 1402426 we no longer need to provide and sign an XPI for the talos add-ons. Remove the talos add-on pageloader-signed.xpi.
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=850ce563d31d408d68d7c25a669599290497a955
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 3•5 years ago
|
||
mozreview-review |
Comment on attachment 8930651 [details] Bug 1412388 - Remove talos pageloader-signed.xpi; https://reviewboard.mozilla.org/r/201780/#review207116 oh cool!
Attachment #8930651 -
Flags: review?(jmaher) → review+
Comment 4•5 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 44df418a2637 -d d9bbfb2a7e42: rebasing 435232:44df418a2637 "Bug 1412388 - Remove talos pageloader-signed.xpi; r=jmaher" (tip) tool internal:merge can't handle binary local [dest] changed testing/talos/talos/pageloader/pageloader-signed.xpi which other [source] deleted use (c)hanged version, (d)elete, or leave (u)nresolved? u unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1182ae0e001b Remove talos pageloader-signed.xpi; r=jmaher
Comment 7•5 years ago
|
||
I've made my changes out of mozilla-central, which still had the pageloader-signed.xpi file. I'm rebasing this onto autoland, then push again.
Assignee | ||
Comment 8•5 years ago
|
||
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #7) > I've made my changes out of mozilla-central, which still had the > pageloader-signed.xpi file. > I'm rebasing this onto autoland, then push again. Not sure what you mean here, this patch has already landed. If you are rebasing a local patch of yours (in a different bug) no need to add a comment to this bug (perhaps you meant to add this comment to a different bug?)
Flags: needinfo?(igoldan)
Comment 9•5 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #8) > (In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #7) > > I've made my changes out of mozilla-central, which still had the > > pageloader-signed.xpi file. > > I'm rebasing this onto autoland, then push again. > > Not sure what you mean here, this patch has already landed. If you are > rebasing a local patch of yours (in a different bug) no need to add a > comment to this bug (perhaps you meant to add this comment to a different > bug?) My comment wasn't correct, actually. I only read comment 4, and thought I had to update my push.
Flags: needinfo?(igoldan)
Assignee | ||
Comment 10•5 years ago
|
||
Ah, comment 4 just meant I tried to land this patch but it couldn't merge because of a conflict - I had to pull the latest, rebase my patch (resolve the conflict), and land it again. :)
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1182ae0e001b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•