Closed
Bug 1412408
Opened 7 years ago
Closed 7 years ago
content process leak of 1 U2FTransactionChild
Categories
(Core :: DOM: Device Interfaces, defect, P1)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox56 | --- | unaffected |
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
People
(Reporter: mccr8, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak, regression, Whiteboard: [MemShrink:P2][u2f])
Attachments
(1 file)
This showed up in the last week, so presumably it is a regression from bug 1403818. Unsurprisingly, this leak shows up while running e10s Mochitests in the dom/u2f/tests/ directory.
|
||
Updated•7 years ago
|
Priority: -- → P1
Whiteboard: [MemShrink] → [MemShrink][u2f]
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•7 years ago
|
||
The problem here is that BackgroundChildImpl::DeallocPWebAuthnTransactionChild() always casts the actor to a WebAuthnTransactionChild, even if it's actually a U2FTransactionChild.
|
||
Updated•7 years ago
|
Whiteboard: [MemShrink][u2f] → [MemShrink:P2][u2f]
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8924197 [details] Bug 1412408 - Fix content process leak of U2FTransactionChild instances r=jcj J.C. Jones [:jcj] has approved the revision. https://phabricator.services.mozilla.com/D179#4501
Attachment #8924197 -
Flags: review+
Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5bfa2ffc98 Fix content process leak of U2FTransactionChild instances r=jcj
|
Reporter | |
Comment 4•7 years ago
|
||
Thanks for the quick fix.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Sure, thanks for spotting it!
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a5bfa2ffc98
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•