content process leak of 1 U2FTransactionChild

RESOLVED FIXED in Firefox 58

Status

()

P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mccr8, Assigned: ttaubert)

Tracking

(Blocks: 1 bug, {memory-leak, regression})

unspecified
mozilla58
memory-leak, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox56 unaffected, firefox57 unaffected, firefox58 fixed)

Details

(Whiteboard: [MemShrink:P2][u2f])

Attachments

(1 attachment)

This showed up in the last week, so presumably it is a regression from bug 1403818. Unsurprisingly, this leak shows up while running e10s Mochitests in the dom/u2f/tests/ directory.
Priority: -- → P1
Whiteboard: [MemShrink] → [MemShrink][u2f]
(Assignee)

Updated

a year ago
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
The problem here is that BackgroundChildImpl::DeallocPWebAuthnTransactionChild() always casts the actor to a WebAuthnTransactionChild, even if it's actually a U2FTransactionChild.
Whiteboard: [MemShrink][u2f] → [MemShrink:P2][u2f]
Comment on attachment 8924197 [details]
Bug 1412408 - Fix content process leak of U2FTransactionChild instances r=jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D179#4501
Attachment #8924197 - Flags: review+

Comment 3

a year ago
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5bfa2ffc98
Fix content process leak of U2FTransactionChild instances r=jcj
Thanks for the quick fix.
Sure, thanks for spotting it!
https://hg.mozilla.org/mozilla-central/rev/3a5bfa2ffc98
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
status-firefox56: --- → unaffected
status-firefox57: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.