Closed
Bug 1412416
Opened 7 years ago
Closed 7 years ago
Simplify ArenaAllocatorExtensions
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
Details
Attachments
(2 files)
|
2.15 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
|
2.82 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Now that we use proper templates for our string types we can simplify ArenaAllocatorExtensions a bit.
|
Assignee | |
Comment 1•7 years ago
|
||
This adds support for duplicating both raw `char*` strings and raw `char16_t*` strings by making the character type generic.
Attachment #8922952 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
Now that xpcom strings use templates we can combine their `ArenaStrdup` implementations. `nsTStringRepr` is used so as to allow handling of both `nsTLiteralString` and `nsTSubstring` types.
Attachment #8922953 -
Flags: review?(nfroyd)
|
||
Updated•7 years ago
|
Attachment #8922952 -
Flags: review?(nfroyd) → review+
|
|
||
Updated•7 years ago
|
Attachment #8922953 -
Flags: review?(nfroyd) → review+
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3aea617d92e Part 1: Support arena duplication of wide strings. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/6bb54c25baf9 Part 2: Simplify ArenaStrdup for xpcom strings. r=froydnj
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f3aea617d92e https://hg.mozilla.org/mozilla-central/rev/6bb54c25baf9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•