Closed
Bug 1412421
Opened 7 years ago
Closed 7 years ago
Change some nsAuto[C]String parameters back to ns[C]String
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 58.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 1 obsolete file)
4.19 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Let's fix some sins of the past ;-)
Assignee | ||
Comment 1•7 years ago
|
||
Eric, could you look at this for me. We're short in Mailnews reviewers. Thanks in advance.
Comment 2•7 years ago
|
||
Comment on attachment 8922956 [details] [diff] [review] 1412421-minor-string-tweaks.patch Review of attachment 8922956 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for cleaning things up! Just a few minor tweaks suggested, r=me with those fixed. ::: mailnews/base/util/nsMsgUtils.cpp @@ +2104,5 @@ > return aValue; > } > > // Helper function to extract a query qualifier. > +nsCString MsgExtractQueryPart(nsCString spec, const char* queryToExtract) Please change `spec` to `const nsACString& spec` (it will avoid a copy). ::: mailnews/compose/src/nsMsgCompose.cpp @@ +4205,5 @@ > * This is intended to be used in for signature files, so that we can make sure > * images loaded into the editor are available on send. > */ > nsresult > +nsMsgCompose::ReplaceFileURLs(nsString &aData) This can stay an auto string since it's an in/out param.
Attachment #8922956 -
Flags: review?(erahm) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Fixed review issues, thanks for the quick turnaround. I had to use int32_t queryIndex = nsPromiseFlatCString(spec).Find(queryToExtract); ^^^^^^^^^^^^^^^^^^^^^ since I can't .Find() on a nsACString. OK?
Attachment #8922956 -
Attachment is obsolete: true
Attachment #8922995 -
Flags: review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/6982e252d9b9 Change some nsAuto[C]String parameters back to ns[C]String. r=erahm
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 58.0
Comment 5•7 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #3) > Created attachment 8922995 [details] [diff] [review] > 1412421-minor-string-tweaks.patch (v2) > > Fixed review issues, thanks for the quick turnaround. > > I had to use > int32_t queryIndex = nsPromiseFlatCString(spec).Find(queryToExtract); > ^^^^^^^^^^^^^^^^^^^^^ > since I can't .Find() on a nsACString. OK? Oh sorry! It has FindChar but not Find :( That works.
You need to log in
before you can comment on or make changes to this bug.
Description
•