1412430 - Move light theme tabstrip vibrancy rule to MacOS-specific stylesheet

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

I am a klutz and added the rule to compacttheme.inc.css in bug 1386721.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1412430 - Move light theme tabstrip vibrancy rule to MacOS-specific stylesheet.

Review commit: https://reviewboard.mozilla.org/r/194160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194160/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8922983 [details]
Bug 1412430 - Move light theme tabstrip vibrancy rule to MacOS-specific stylesheet.

https://reviewboard.mozilla.org/r/194160/#review199220

::: browser/themes/osx/compacttheme.css:12
(Diff revision 1)
> +#TabsToolbar:-moz-lwtheme-darktext {
> +  -moz-appearance: -moz-mac-vibrancy-light;
> +}

needs to be yosemite only too

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8922983 [details]
Bug 1412430 - Move light theme tabstrip vibrancy rule to MacOS-specific stylesheet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194160/diff/1-2/

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Tim Nguyen :ntim from comment #2)
> Comment on attachment 8922983 [details]
> Bug 1412430 - Move light theme tabstrip vibrancy rule to MacOS-specific
> stylesheet.
> 
> https://reviewboard.mozilla.org/r/194160/#review199220
> 
> ::: browser/themes/osx/compacttheme.css:12
> (Diff revision 1)
> > +#TabsToolbar:-moz-lwtheme-darktext {
> > +  -moz-appearance: -moz-mac-vibrancy-light;
> > +}
> 
> needs to be yosemite only too

Hmm, we're not using any special selectors for this for the default theme; I believe on pre-Yosemite -moz-mac-vibrancy-* doesn't do anything and it falls back to the background-color.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8922983 [details]
Bug 1412430 - Move light theme tabstrip vibrancy rule to MacOS-specific stylesheet.

https://reviewboard.mozilla.org/r/194160/#review199228

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d773bc1b9b8
Move light theme tabstrip vibrancy rule to MacOS-specific stylesheet. r=dao

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7d773bc1b9b8

Comment 8

[Matthew N. [:MattN]]

Screenshot changes for compactLight: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=908af7f6a7257012a6cdd90f95dcd9b04f56c832&newProject=mozilla-central&newRev=d205f9c3b456d1c5cf7c629bd5d424f2562ccc72&filter=osx.*compactLight

Comment 9

[ovidiu boca[:Ovidiu]]

Hi Nihanth, can you please help us here and tell us how we should verify this issue? Thanks

Comment 10

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to ovidiu boca[:Ovidiu] from comment #9)
> Hi Nihanth, can you please help us here and tell us how we should verify
> this issue? Thanks

This bug should have no visible impact on the UI. I.e. you can mark this verified if there is no observable change between this and bug 1386721.

Comment 11

[ovidiu boca[:Ovidiu]]

Thanks Nihanth, I will mark this as verified.