Closed Bug 1412431 Opened 2 years ago Closed 2 years ago

Remove MOZ_BUILD_PROJECTS support

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

With the removal of support for Universal MacOS builds, I'm reasonably confident we no longer have a need to support MOZ_PREFLIGHT and MOZ_POSTFLIGHT. The %_ALL versions, yes, we still need. But the per-project support can be removed AFAICT.
It certainly looks like MOZ_BUILD_PROJECTS can be nuked. This wider scope is a much, much nicer cleanup :)
Summary: Clean up MOZ_PREFLIGHT support → Remove MOZ_BUILD_PROJECTS support
Comment on attachment 8922991 [details]
Bug 1412431 - Remove unused BASE_DIR variable;

https://reviewboard.mozilla.org/r/194166/#review199192

::: commit-message-d4dee:1
(Diff revision 2)
> +Bug 1412431 - Remove unsued BASE_DIR variable; r?build

s/unsued/unused/.  Although an absence of legal action is likely correct :)
Attachment #8922991 - Flags: review+
Comment on attachment 8922993 [details]
Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT;

https://reviewboard.mozilla.org/r/194170/#review199196

::: commit-message-259d4:3
(Diff revision 2)
> +Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r?build
> +
> +These variables are unused in the repo. The %_ALL variation is used for

We should track getting rid of this sccache business; that should be the purview of the |mach| invocation, I think.  File and reference?
Attachment #8922993 - Flags: review+
Comment on attachment 8922994 [details]
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS;

https://reviewboard.mozilla.org/r/194182/#review199198

lgtm.  I'm not really familiar with this code -- so much cruft! -- but it all looks like the patch I'd write to achieve this end.  \o/ to simplifying our lives!

::: commit-message-44020:15
(Diff revision 3)
> +mozconfigs, I don't think support for this feature is worth keeping.
> +
> +This commit removes support for MOZ_BUILD_PROJECTS and related
> +functionality from client.mk. Support for recognizing
> +MOZ_CURRENT_PROJECT in configure and mozconfig evaluation has also
> +been removed. This includes support for the ac_add_app_options

Hmm, this could bust `mozconfig` files in the wild.  Worth keeping an eye on for follow-up, I guess.
Attachment #8922994 - Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad8c9b900308
Remove unused BASE_DIR variable; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/b676880e0d97
Remove MOZ_UNIFY_BDATE; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/5e5ee518a4b9
Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/5fb427c50ca3
Remove support for MOZ_BUILD_PROJECTS; r=nalexander
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c78fdb772452
Remove docs for removed ac_add_app_options; r=me
Attachment #8922991 - Flags: review?(core-build-config-reviews)
Attachment #8922992 - Flags: review?(core-build-config-reviews)
Attachment #8922993 - Flags: review?(core-build-config-reviews)
Attachment #8922994 - Flags: review?(core-build-config-reviews)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.