1412431 - Remove MOZ_BUILD_PROJECTS support

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

With the removal of support for Universal MacOS builds, I'm reasonably confident we no longer have a need to support MOZ_PREFLIGHT and MOZ_POSTFLIGHT. The %_ALL versions, yes, we still need. But the per-project support can be removed AFAICT.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1412431 - Remove unused BASE_DIR variable;

This variable has been unused since 683e59dc3094 (bug 1286934).

Review commit: https://reviewboard.mozilla.org/r/194166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194166/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1412431 - Remove MOZ_UNIFY_BDATE;

There are no references to this variable outside client.mk. AFAICT
it is unused.

The only reasonable justification for retaining this support IMO was
Universal MacOS builds. And those are no longer supported.

Review commit: https://reviewboard.mozilla.org/r/194168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194168/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT;

These variables are unused in the repo. The %_ALL variation is used for
sccache, however.

The last use of these variables was removed when support for MacOS
universal builds was removed.

Someone somewhere may be relying on this functionality. But I don't
think it is worth continuing to support in client.mk. If someone
really needs it, we can reintroduce support for the feature elsewhere,
like in mach or via mozconfig support somehow.

Review commit: https://reviewboard.mozilla.org/r/194170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194170/

Comment 4

[Gregory Szorc [:gps]]

Attachment: Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS;

This was mainly used to support Universal MacOS builds, which were
removed several months ago.

In theory, someone could be using this feature to build multiple
applications with one build system invocation. But given that client.mk
is no longer the preferred interface to the build system and multiple
applications can be built by running `mach build` with different
mozconfigs, I don't think support for this feature is worth keeping.

This commit removes support for MOZ_BUILD_PROJECTS and related
functionality from client.mk. Support for recognizing
MOZ_CURRENT_PROJECT in configure and mozconfig evaluation has also
been removed. This includes support for the ac_add_app_options
mozconfig function.

Good riddance.

Review commit: https://reviewboard.mozilla.org/r/194182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194182/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8922994 [details]
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194182/diff/1-2/

Comment 6

[Gregory Szorc [:gps]]

It certainly looks like MOZ_BUILD_PROJECTS can be nuked. This wider scope is a much, much nicer cleanup :)

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8922991 [details]
Bug 1412431 - Remove unused BASE_DIR variable;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194166/diff/1-2/

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8922992 [details]
Bug 1412431 - Remove MOZ_UNIFY_BDATE;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194168/diff/1-2/

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8922993 [details]
Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194170/diff/1-2/

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8922994 [details]
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194182/diff/2-3/

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8922991 [details]
Bug 1412431 - Remove unused BASE_DIR variable;

https://reviewboard.mozilla.org/r/194166/#review199192

::: commit-message-d4dee:1
(Diff revision 2)
> +Bug 1412431 - Remove unsued BASE_DIR variable; r?build

s/unsued/unused/.  Although an absence of legal action is likely correct :)

Comment 12

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8922992 [details]
Bug 1412431 - Remove MOZ_UNIFY_BDATE;

https://reviewboard.mozilla.org/r/194168/#review199194

Comment 13

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8922993 [details]
Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT;

https://reviewboard.mozilla.org/r/194170/#review199196

::: commit-message-259d4:3
(Diff revision 2)
> +Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r?build
> +
> +These variables are unused in the repo. The %_ALL variation is used for

We should track getting rid of this sccache business; that should be the purview of the |mach| invocation, I think.  File and reference?

Comment 14

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8922994 [details]
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS;

https://reviewboard.mozilla.org/r/194182/#review199198

lgtm.  I'm not really familiar with this code -- so much cruft! -- but it all looks like the patch I'd write to achieve this end.  \o/ to simplifying our lives!

::: commit-message-44020:15
(Diff revision 3)
> +mozconfigs, I don't think support for this feature is worth keeping.
> +
> +This commit removes support for MOZ_BUILD_PROJECTS and related
> +functionality from client.mk. Support for recognizing
> +MOZ_CURRENT_PROJECT in configure and mozconfig evaluation has also
> +been removed. This includes support for the ac_add_app_options

Hmm, this could bust `mozconfig` files in the wild.  Worth keeping an eye on for follow-up, I guess.

Comment 15

[Gregory Szorc [:gps]]

Comment on attachment 8922991 [details]
Bug 1412431 - Remove unused BASE_DIR variable;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194166/diff/2-3/

Comment 16

[Gregory Szorc [:gps]]

Comment on attachment 8922992 [details]
Bug 1412431 - Remove MOZ_UNIFY_BDATE;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194168/diff/2-3/

Comment 17

[Gregory Szorc [:gps]]

Comment on attachment 8922993 [details]
Bug 1412431 - Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194170/diff/2-3/

Comment 18

[Gregory Szorc [:gps]]

Comment on attachment 8922994 [details]
Bug 1412431 - Remove support for MOZ_BUILD_PROJECTS;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194182/diff/3-4/

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad8c9b900308
Remove unused BASE_DIR variable; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/b676880e0d97
Remove MOZ_UNIFY_BDATE; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/5e5ee518a4b9
Remove support for MOZ_PREFLIGHT and MOZ_POSTFLIGHT; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/5fb427c50ca3
Remove support for MOZ_BUILD_PROJECTS; r=nalexander

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c78fdb772452
Remove docs for removed ac_add_app_options; r=me

Comment 21

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ad8c9b900308
https://hg.mozilla.org/mozilla-central/rev/b676880e0d97
https://hg.mozilla.org/mozilla-central/rev/5e5ee518a4b9
https://hg.mozilla.org/mozilla-central/rev/5fb427c50ca3

Comment 22

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c78fdb772452