Closed
Bug 1412439
Opened 7 years ago
Closed 7 years ago
gPrivacyPane.updateActualCacheSize calls asyncVisitStorage on nsICacheStorageService instead of nsICacheStorage
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: myk, Assigned: myk)
References
Details
Attachments
(1 file)
|
967 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Bug 1230373 regressed gPrivacyPane.updateActualCacheSize, making it call asyncVisitStorage on nsICacheStorageService (which doesn't have such a method) instead of nsICacheStorage:
https://hg.mozilla.org/mozilla-central/rev/c072884b1b90#l35.119
Unfortunately, the failure is silent, since a try block with an empty catch block surrounds the failing code. And the consequences of failure are apparently not covered by tests.
In any case, here's the regression fix.
|
Assignee | |
Comment 1•7 years ago
|
||
Erm, I mean *here* is the regression fix.
Attachment #8922997 -
Flags: review?(dtownsend)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8922997 [details] [diff] [review]
call asyncVisitStorage on nsICacheStorage instance
Review of attachment 8922997 [details] [diff] [review]:
-----------------------------------------------------------------
Oops!
Attachment #8922997 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
This has just been obsoleted by bug 1399808, which removed the errant code. So I'm resolving this bug fixed without landing the patch.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•