1412443 - Port |Bug 1408789 - Use VS2017 for official Windows builds|

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Sadly it wasn't as easy as:
https://hg.mozilla.org/comm-central/rev/103523d052a8ea9ea3b800d3d4328e48d113502f

so I backed that out again:
https://hg.mozilla.org/comm-central/rev/6c1a4df211346f193535e3d5a2e4281b1984837b

Comment 1

[Tom Prince [:tomprince]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=336ae9300b8c7274544b934fee15aa6f5016067b

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks, but I think you need to add build/win64/mozconfig.vs2017 and build/win32/mozconfig.vs2017.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1412443-vs2017.patch

This might be it:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=154e4adbd81c9bacd4a92101c08aeafb8898796a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/06612f10c21a
Port bug 1408789: Switch Windows builders to VS2017 15.4.1 with SDK 10.0.16299.0. rs=bustage-fix

Comment 5

[Jorg K (CEST = GMT+2)]

The try run from comment #3 is two hours overdue at time of writing, so I landed what I had. We might need to land a follow-up. At least it didn't fail after a few minutes due to misconfiguration.

Comment 6

[Richard Marti (:Paenglab)]

VS2017 is slower on my machine than VS2015 (~85 min to ~60min clobber build).

Comment 7

[Jorg K (CEST = GMT+2)]

The try run finally failed with:
checking for the target C compiler... c:/builds/moz2_slave/tb-try-c-cen-w32-0000000000000/build/vs2017_15.4.1/VC/bin/Hostx64/x86/cl.exe
checking whether the target C compiler can be used... 
command timed out: 10800 seconds without output running ['python', 'c:/builds/moz2_slave/tb-try-c-cen-w32-0000000000000/build/build/pymake/make.py', '-f', 'client.mk', 'build', 'MOZ_BUILD_DATE=20171027232725'], attempting to kill
SIGKILL failed to kill process.

So looks like we need to fix this in a follow-up if it also fails on the push from comment #4.

Comment 8

[Jorg K (CEST = GMT+2)]

Looks like Win64 works but Win32 hangs:
checking whether cross compiling... no
checking for the target C compiler... c:/builds/moz2_slave/tb-try-c-cen-w32-0000000000000/build/vs2017_15.4.1/VC/bin/Hostx64/x86/cl.exe
checking whether the target C compiler can be used... 
command timed out: 10800 seconds without output running ...

Comparing to a FF build
08:48:15     INFO -  checking for the target C compiler... z:/build/build/src/vs2017_15.4.1/VC/bin/Hostx64/x86/cl.exe
08:48:16     INFO -  checking whether the target C compiler can be used... yes
I don't see why it doesn't work for TB.

Comment 9

[Jorg K (CEST = GMT+2)]

Check this:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=395acea4a3e753488ca38d56c51654d151d50d6c
Win32 timed out, Win64 built. Weird.

Comment 10

[Tom Prince [:tomprince]]

It looks like VS2017 doesn't support Windows XP, which is where we do our win32 builds, so trying to run it fails (apparently by hanging somehow, which is odd).

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0cc4a14644c77b672da24def2e8655ac2577d294 should fix it, but it depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1410475 the M-C part of it has landed on autoland. I'll land it once the m-c merge is done.

Comment 11

[Jorg K (CEST = GMT+2)]

Thanks. I was wondering whether the treeherder was lying and "XP" was just an incorrect label. Apparently not :-(

Comment 12

[Jorg K (CEST = GMT+2)]

Looks like https://hg.mozilla.org/integration/autoland/rev/c7ae1c6f2a49 will get merged on Tuesday around 12:00 GMT. If you attach the C-C patches here (I can see them on try), I can land them for you.

Comment 13

[Frank-Rainer Grahl (:frg)]

> It looks like VS2017 doesn't support Windows XP, which is where we do our win32 builds, so trying to run it fails (apparently by hanging somehow, which is odd).

You mean the VS2015 compiler package still is usable in XP? If yes interesting. I know the VS2017 runtime still supports XP SP3 but the compiler was never supported on anything less than Win 7 and SP1.

Comment 14

[Tom Prince [:tomprince]]

Attachment: Bug 1412443: Don't use VS 2017 on win32 in buildbot, as Windows XP isn't supported by it; rs=bustage-fix

Review commit: https://reviewboard.mozilla.org/r/195018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195018/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ff617d6bb34
Don't use VS 2017 on win32 in buildbot, as Windows XP isn't supported by it; rs=bustage-fix

Comment 16

[Edmund Wong (:ewong)]

(In reply to Pulsebot from comment #15)
> Pushed by [e-mail]:
> https://hg.mozilla.org/comm-central/rev/4ff617d6bb34
> Don't use VS 2017 on win32 in buildbot, as Windows XP isn't supported by it;
> rs=bustage-fix

Fwiw..  TB doesn't build on XP.  It builds on spot instances using Windows 2008r2.
AWS spot instances don't have XP since VS2015 doesn't even run on XP.

The XP is left over from when TB used to build on XPs (or such) and wasn't updated.

  MOZ_TOOLS=C:\mozilla-build\moztools-x64
  MSYSTEM=MINGW32
  NUMBER_OF_PROCESSORS=16
  OLDPWD=c:/Users/cltbld
  OS=Windows_NT
  OSTYPE=msys
  OS_VERSION=2008