Closed Bug 1412509 Opened 3 years ago Closed 3 years ago

Follow bug 1411642 with a change in msgMail3PaneWindow.js

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

All
Windows 10
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1411642 changed a part of the code we already had but removed one if() condition.
They are doing now the same height calculation as we do. But they removed one if() condition by adding it to the parent condition. See https://hg.mozilla.org/mozilla-central/rev/fe42b971c838
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8923074 - Flags: review?(jorgk)
Actually, they removed the +1:

-      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) {
-        if (!menuHeight) {
-          // Add a pixel to slightly overlap the navbar border.
-          titlebarContentHeight = fullTabsHeight + 1;   <=====
-          $("titlebar-buttonbox").style.height = titlebarContentHeight + "px";
-        }
+      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") &&
+          !menuHeight) {
+        titlebarContentHeight = fullTabsHeight;
+        $("titlebar-buttonbox").style.height = titlebarContentHeight + "px";
       }

We follow that?
(In reply to Jorg K (GMT+2) from comment #2)
> Actually, they removed the +1:

Correct, we never used it because of the jumping window buttons when showing the autohide menubar.

> -      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) {
> -        if (!menuHeight) {
> -          // Add a pixel to slightly overlap the navbar border.
> -          titlebarContentHeight = fullTabsHeight + 1;   <=====
> -          $("titlebar-buttonbox").style.height = titlebarContentHeight +
> "px";
> -        }
> +      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") &&
> +          !menuHeight) {
> +        titlebarContentHeight = fullTabsHeight;
> +        $("titlebar-buttonbox").style.height = titlebarContentHeight + "px";
>        }
> 
> We follow that?

For us is only that change important:

-      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) {
-        if (!menuHeight) {
+      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") &&
+          !menuHeight) {

The other lines are only indentation changes because of the removed if().
Comment on attachment 8923074 [details] [diff] [review]
msgMail3PaneWindow.patch

OK. We're currently very busted, so no idea when I'll land this.
Attachment #8923074 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/891c8dc1e07e
Follow bug 1411642 with a change in msgMail3PaneWindow.js. r=jorgk CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.