1412509 - Follow bug 1411642 with a change in msgMail3PaneWindow.js

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1411642 changed a part of the code we already had but removed one if() condition.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: msgMail3PaneWindow.patch

They are doing now the same height calculation as we do. But they removed one if() condition by adding it to the parent condition. See https://hg.mozilla.org/mozilla-central/rev/fe42b971c838

Comment 2

[Jorg K (CEST = GMT+2)]

Actually, they removed the +1:

-      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) {
-        if (!menuHeight) {
-          // Add a pixel to slightly overlap the navbar border.
-          titlebarContentHeight = fullTabsHeight + 1;   <=====
-          $("titlebar-buttonbox").style.height = titlebarContentHeight + "px";
-        }
+      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") &&
+          !menuHeight) {
+        titlebarContentHeight = fullTabsHeight;
+        $("titlebar-buttonbox").style.height = titlebarContentHeight + "px";
       }

We follow that?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #2)
> Actually, they removed the +1:

Correct, we never used it because of the jumping window buttons when showing the autohide menubar.

> -      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) {
> -        if (!menuHeight) {
> -          // Add a pixel to slightly overlap the navbar border.
> -          titlebarContentHeight = fullTabsHeight + 1;   <=====
> -          $("titlebar-buttonbox").style.height = titlebarContentHeight +
> "px";
> -        }
> +      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") &&
> +          !menuHeight) {
> +        titlebarContentHeight = fullTabsHeight;
> +        $("titlebar-buttonbox").style.height = titlebarContentHeight + "px";
>        }
> 
> We follow that?

For us is only that change important:

-      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0")) {
-        if (!menuHeight) {
+      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") &&
+          !menuHeight) {

The other lines are only indentation changes because of the removed if().

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8923074 [details] [diff] [review]
msgMail3PaneWindow.patch

OK. We're currently very busted, so no idea when I'll land this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/891c8dc1e07e
Follow bug 1411642 with a change in msgMail3PaneWindow.js. r=jorgk CLOSED TREE