Closed Bug 1412574 Opened 4 years ago Closed 3 years ago
remove the charset argument of encode
Mime Part IIStr _UTF8 in MIME
All callers of encodeMimePartIIStr_UTF8() now specify UTF-8 as the charset, which is the wished state, and no other charset is supported, so the argument can be removed now.
Attachment #8923155 - Flags: review?(Pidgeot18) → review?(jorgk)
I checked DXR and it looks like you covered everything.
Actually, ChromeUtils.import("resource://gre/modules/Deprecated.jsm"); can be removed from mimeJSComponents.js since it doesn't issue any deprecation warning any more.
Thanks. The patch was badly bitrotted, but it seems you refreshed it.
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/3bcadb80b567 remove unused charset argument of encodeMimePartIIStr_UTF8. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Actually, not really badly bit-rotten. Four hunks failed, and of those, I could fix three by editing the patch: - do_check_eq -> Assert.equal - XPCOMUtils.generateQI([Components.interfaces. -> ChromeUtils.generateQI([Ci. - function* -> async function. Only nsMsgUtils.cpp needed an easy intervention of a different kind. I'm looking at cleaning up Joshua's and Kent's review queues, so stand by for more action coming to you sooner or later ;-)
Target Milestone: --- → Thunderbird 63.0
You need to log in before you can comment on or make changes to this bug.