Closed
Bug 1412574
Opened 8 years ago
Closed 7 years ago
remove the charset argument of encodeMimePartIIStr_UTF8 in MIME
Categories
(MailNews Core :: MIME, enhancement)
MailNews Core
MIME
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 63.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.58 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
All callers of encodeMimePartIIStr_UTF8() now specify UTF-8 as the charset, which is the wished state, and no other charset is supported, so the argument can be removed now.
Attachment #8923155 -
Flags: review?(Pidgeot18)
|
||
Updated•7 years ago
|
Attachment #8923155 -
Flags: review?(Pidgeot18) → review?(jorgk)
|
|
||
Comment 2•7 years ago
|
||
I checked DXR and it looks like you covered everything.
Attachment #8923155 -
Attachment is obsolete: true
Attachment #8923155 -
Flags: review?(jorgk)
Attachment #8990452 -
Flags: review+
|
|
||
Comment 3•7 years ago
|
||
Actually, ChromeUtils.import("resource://gre/modules/Deprecated.jsm"); can be removed from mimeJSComponents.js since it doesn't issue any deprecation warning any more.
Thanks.
The patch was badly bitrotted, but it seems you refreshed it.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3bcadb80b567
remove unused charset argument of encodeMimePartIIStr_UTF8. r=jorgk
|
|
||
Comment 6•7 years ago
|
||
Actually, not really badly bit-rotten. Four hunks failed, and of those, I could fix three by editing the patch:
- do_check_eq -> Assert.equal
- XPCOMUtils.generateQI([Components.interfaces. -> ChromeUtils.generateQI([Ci.
- function* -> async function.
Only nsMsgUtils.cpp needed an easy intervention of a different kind.
I'm looking at cleaning up Joshua's and Kent's review queues, so stand by for more action coming to you sooner or later ;-)
Target Milestone: --- → Thunderbird 63.0
You need to log in
before you can comment on or make changes to this bug.
Description
•