1412588 - Update rustc tooltool package to 1.21

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

need to update rust to 1.21

Comment 1

[Edmund Wong (:ewong)]

Attachment: [tooltool] update rustc packages

Comment 2

[Edmund Wong (:ewong)]

going to bustagefix-post-land-review this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf29aafeeae3
Update Rust to 1.21 r=bustagefix

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36ad3fb2f6cb
Update Rust to 1.21 r=bustagefix

Comment 5

[Edmund Wong (:ewong)]

(In reply to Pulsebot from comment #4)
> Pushed by [e-mail]:
> https://hg.mozilla.org/comm-central/rev/36ad3fb2f6cb
> Update Rust to 1.21 r=bustagefix

this was a bustagefix..

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8923138 [details] [diff] [review]
[tooltool] update rustc packages

Looks fine. Thanks

Comment 7

[Frank-Rainer Grahl (:frg)]

It looks now that the packages need to be uploaded to tooltool for use in TB and SM. See Bug 1412290.

Comment 8

[Edmund Wong (:ewong)]

Comment on attachment 8923138 [details] [diff] [review]
[tooltool] update rustc packages

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: no builds on beta
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 9

[Ian Neal]

Comment on attachment 8923138 [details] [diff] [review]
[tooltool] update rustc packages

a=me

Comment 10

[Jorg K (CEST = GMT+2)]

I think it was a mistake to uplift this to C-B for the following reason:

Mozilla have merged M-C to M-B very early this time. Therefore we're trying to build a C-B version of 57 onto an M-B version of 58 which clearly will fail.

Updating Rust to 1.21 will get you past the first hurdle, but I'm sure you can't even compile anything.

If you want to build a beta, you need to base it on the FIREFOX_57b_RELBRANCH on M-B.

If you agree, please back this out:
https://hg.mozilla.org/releases/comm-beta/rev/44259af6a276b20ac07acfed8dae334a446f0795

Comment 11

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/882f957d55226d813fdf6f5f9d57480cb15e5d19