1412608 - Fix comment selection color in markup view

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[magicp]

Attachment: comment-selection-color-in-markup.png

Steps to reproduce:
1. Start Firefox 57b or Nightly
2. Open "https://www.mozilla.org/en-US/contribute/"
3. Open Inspector
4. Select any comments in markup view

Actual Results:
Selection color is var(--theme-highlight-green). Green and blue background is hard to see.

Expected Results:
Selection color is var(--theme-selection-color).

For example...
:not(.theme-selected) .editor.comment:not(.doctype) {
  color: var(--theme-highlight-green);
}

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f255ec4e8c361e4526b7bfb1083cecb41fabbdd1&tochange=246cba2233e3103ac3e0f160c40ccec9e6946ec9

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1412608 - Fix comment selection color in markup view.

Review commit: https://reviewboard.mozilla.org/r/198380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198380/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8927139 [details]
Bug 1412608 - Fix comment selection color in markup view.

https://reviewboard.mozilla.org/r/198380/#review203700

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/411876ddf288
Fix comment selection color in markup view. r=jdescottes

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fba6117d270
Fix comment selection color in markup view. r=jdescottes

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/411876ddf288

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9fba6117d270

Comment 7

[magicp]

This bug fix has verified in the latest Nightly Build ID:20171112100435. Thanks!