1412641 - [Static Analysis] Uninitialized fields in some classes of accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Tristan Bourvon]

As part of the static analysis effort to ensure all class fields are initialized before usage (see https://bugzilla.mozilla.org/show_bug.cgi?id=525063), here are a few fixes to the accessibility module.

Comment 1

[Tristan Bourvon]

Attachment: accessibility.patch

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 8923160 [details] [diff] [review]
accessibility.patch

Review of attachment 8923160 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/TextAttrs.h
@@ +399,4 @@
>    class TextDecorValue
>    {
>    public:
> +    TextDecorValue() : mColor{0}, mLine{'\0'}, mStyle{'\0'} { }

those are ints not characters, so STYLE_TEXT_DECORATION_LINE_NONE for mLine and NS_STYLE_TEXT_DECORATION_STYLE_NONE for mStyle would be more reasonable values.

::: accessible/base/nsAccessiblePivot.cpp
@@ +21,4 @@
>  {
>  public:
>    explicit RuleCache(nsIAccessibleTraversalRule* aRule) : mRule(aRule),
> +                                                          mAcceptRoles(nullptr), mAcceptRolesLength{0}, mPreFilter{0} { }

nit: could you please change styling while you are here?
explicit RuleCache(nsIAccessibleTraversalRule* aRule) :
  mRule(aRule), mAcceptRoles(nullptr),
  mAcceptRolesLength{0}, mPreFilter{0}
{
}

Comment 4

[Andi [:andi]]

This should be backed out because it busts the build. A new patch is underway.

Comment 5

[Andi [:andi]]

Since the previous push to m-i has been backed out due to build bustage, I've submitted a try build with the new changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1f1129c992eda347978c767893d6c0e1423d71b

Comment 6

[Andi [:andi]]

pushed to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/72522cd7b6e3d46469631f670470bc7b86b87db7

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/72522cd7b6e3