1412648 - [Static Analysis] Uninitialized fields in some classes of tools/profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Tristan Bourvon]

As part of the static analysis effort to ensure all class fields are initialized before usage (see https://bugzilla.mozilla.org/show_bug.cgi?id=525063), here are a few fixes to the tools/profiler module.

Comment 1

[Tristan Bourvon]

Attachment: tools_profiler.patch

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8923166 [details] [diff] [review]
tools_profiler.patch

Review of attachment 8923166 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/core/ProfilerMarker.h
@@ +27,5 @@
>                            double aTime = 0)
>      : mMarkerName(strdup(aMarkerName))
>      , mPayload(Move(aPayload))
> +    , mNext{nullptr}, mTime(aTime)
> + , mGenID{0} {}

separate lines + bad indent

::: tools/profiler/core/platform.cpp
@@ +2498,3 @@
>  }
>  AutoSetProfilerEnvVarsForChildProcess::AutoSetProfilerEnvVarsForChildProcess(
> +  MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL) : mSetEntries(), mSetInterval(), mSetFeaturesBitfield(), mSetFilters()

These need to go on separate lines. Please follow the example at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes .

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41566b43f974