141265 - FrameManager::ReparentStyleContext should share more code with ReResolveStyleContext

Status: NEW

(Core :: CSS Parsing and Computation, defect, P5)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FrameManager::ReParentStyleContext has all the bugs that
FrameManager::ReResolveStyleContext used to.  I think nobody uses it, so it can
be removed.  If not, it needs all the fixes that ReResolveStyleContext has
(thanks to the sibling sharing optimization -- otherwise it would be much easier).

Comment 1

[Madhur Bhatia]

cc'ing myself

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the best way to fix this would be to ensure that all the callers of
ReParentStyleContext are doing things accounted for by
GetParentStyleContextFrame and then make ReParentStyleContext call
ReResolveStyleContext with a special parameter saying not to find a new rule
node (and perhaps not to build a change list).

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, never mind the previous comment.  But the two could use a single helper
function to do most of the work.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is mostly done by bug 322348, although we could use more code sharing.  (Or is that not possible?)