FrameManager::ReparentStyleContext should share more code with ReResolveStyleContext

RESOLVED INACTIVE

Status

()

Core
CSS Parsing and Computation
P5
normal
RESOLVED INACTIVE
16 years ago
19 hours ago

People

(Reporter: David Baron, Unassigned)

Tracking

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [whitebox])

(Reporter)

Description

16 years ago
FrameManager::ReParentStyleContext has all the bugs that
FrameManager::ReResolveStyleContext used to.  I think nobody uses it, so it can
be removed.  If not, it needs all the fixes that ReResolveStyleContext has
(thanks to the sibling sharing optimization -- otherwise it would be much easier).
(Reporter)

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.1beta

Comment 1

16 years ago
cc'ing myself
(Reporter)

Updated

16 years ago
Target Milestone: mozilla1.1beta → mozilla1.2alpha
(Reporter)

Updated

16 years ago
Target Milestone: mozilla1.2alpha → Future

Updated

16 years ago
Whiteboard: [dev notes]

Updated

16 years ago
Whiteboard: [dev notes] → [whitebox]
(Reporter)

Comment 2

16 years ago
I think the best way to fix this would be to ensure that all the callers of
ReParentStyleContext are doing things accounted for by
GetParentStyleContextFrame and then make ReParentStyleContext call
ReResolveStyleContext with a special parameter saying not to find a new rule
node (and perhaps not to build a change list).
(Reporter)

Comment 3

16 years ago
Er, never mind the previous comment.  But the two could use a single helper
function to do most of the work.
(Reporter)

Updated

16 years ago
Blocks: 143775
(Reporter)

Comment 4

11 years ago
This is mostly done by bug 322348, although we could use more code sharing.  (Or is that not possible?)
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: ian → style-system
Summary: FrameManager::ReParentStyleContext should be removed or fixed → FrameManager::ReParentStyleContext should share more code
(Reporter)

Updated

7 years ago
Summary: FrameManager::ReParentStyleContext should share more code → FrameManager::ReparentStyleContext should share more code with ReResolveStyleContext
(Reporter)

Updated

7 years ago
Priority: P1 → P5

Comment 5

19 hours ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 19 hours ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.