FrameManager::ReParentStyleContext has all the bugs that FrameManager::ReResolveStyleContext used to. I think nobody uses it, so it can be removed. If not, it needs all the fixes that ReResolveStyleContext has (thanks to the sibling sharing optimization -- otherwise it would be much easier).
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.1beta
I think the best way to fix this would be to ensure that all the callers of ReParentStyleContext are doing things accounted for by GetParentStyleContextFrame and then make ReParentStyleContext call ReResolveStyleContext with a special parameter saying not to find a new rule node (and perhaps not to build a change list).
Er, never mind the previous comment. But the two could use a single helper function to do most of the work.
13 years ago
This is mostly done by bug 322348, although we could use more code sharing. (Or is that not possible?)
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: ian → style-system
Summary: FrameManager::ReParentStyleContext should be removed or fixed → FrameManager::ReParentStyleContext should share more code
Summary: FrameManager::ReParentStyleContext should share more code → FrameManager::ReparentStyleContext should share more code with ReResolveStyleContext
Status: NEW → RESOLVED
Last Resolved: 19 hours ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.