1412650 - Switch services.* code to use HttpsURLConnection

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, enhancement, P3)

Description

[:Grisha Kruglov]

Example of an API transition of the favicons code: Bug 1254089. We'll gain SNI support and make very good progress towards entirely removing ch.boye stuff from the codebase.

I imagine the work to be mostly mechanical. Surface area involved is not very large. Mainly we're looking at transitioning FxAccountClient, Token server, and Sync storage classes.

This is likely a good time to also re-asses which cipher suits we're using, a la another round of Bug 1061273.

Comment 2

[Richard Newman [:rnewman]]

N.B., test on the full range of supported Android versions -- supported cipher suites have changed over time.

I believe you can pass an SSLFactory to control which suites are used in HttpsURLConnection. If we can, it would be good to keep them the same; this will reduce the chances of error.

Be on the lookout for keepalive/pooling behavior, correct proxying (https://developer.android.com/reference/java/net/URL.html#openConnection(java.net.Proxy)), and lack of response buffering.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.