./mach bootstrap should install Android NDK r15c

RESOLVED FIXED in Firefox 58

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
24 days ago
22 days ago

People

(Reporter: m_kato, Unassigned)

Tracking

unspecified
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

24 days ago
After landing bug 1163171, our taskcluster uses NDK r15c.  So we should install NDK r15c via ./mach bootstrap too.
Nick, how far away is the all-singing, all-dancing, pull-everything-in-with-the-android-SDK-package-manager update?  For this sort of thing in the short term, maybe we should just define an NDK toolchain job that uses the same mechanism `mach bootstrap` does to repackage the NDK.  That would ensure we wouldn't be getting out of sync between our automation requirements and what local developers use.
Flags: needinfo?(nalexander)
Comment hidden (mozreview-request)
(In reply to Nathan Froyd [:froydnj] from comment #1)
> Nick, how far away is the all-singing, all-dancing,
> pull-everything-in-with-the-android-SDK-package-manager update?

Well... you can add ndk-bundle to http://searchfox.org/mozilla-central/source/python/mozboot/mozboot/android-packages.txt... it's just that Google, in their infinite wisdom, doesn't explicitly version the ndk-bundle package, so you get whatever's current.  Yay, Google.

It is technically possible -- although 100% not obvious how to actually do it -- to host your own "repository definition", pinning the various sdkmanager packages to fixed versions and URLs.  There are posts on SO about doing this, but no details.  I looked and it's... icky.  But it may be something we need to do.

> For this
> sort of thing in the short term, maybe we should just define an NDK
> toolchain job that uses the same mechanism `mach bootstrap` does to
> repackage the NDK.  That would ensure we wouldn't be getting out of sync
> between our automation requirements and what local developers use.

We should add an NDK repackaging task and use it in the bootstrap, yes.
Flags: needinfo?(nalexander)
Comment on attachment 8923441 [details]
Bug 1412677 - Install NDK r15c as part of 'mach bootstrap'

https://reviewboard.mozilla.org/r/194590/#review199570
Attachment #8923441 - Flags: review?(nfroyd) → review+

Comment 5

23 days ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cf89a007576
Install NDK r15c as part of 'mach bootstrap' r=froydnj

Comment 6

23 days ago
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ea2db5c7c86
Install NDK r15c as part of 'mach bootstrap' r=froydnj
https://hg.mozilla.org/mozilla-central/rev/7cf89a007576
Status: NEW → RESOLVED
Last Resolved: 22 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
https://hg.mozilla.org/mozilla-central/rev/9ea2db5c7c86

Comment 9

22 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ea2db5c7c86
You need to log in before you can comment on or make changes to this bug.