Open
Bug 1412694
Opened 7 years ago
Updated 2 years ago
Consider adding a flag similar to isRunningCompositor for throttled animations in out-of-view elements
Categories
(Core :: DOM: Animation, enhancement, P3)
Core
DOM: Animation
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox58 | --- | affected |
People
(Reporter: hiro, Unassigned)
Details
Attachments
(2 files)
6.03 KB,
patch
|
Details | Diff | Splinter Review | |
2.00 KB,
patch
|
Details | Diff | Splinter Review |
Or rename isRunningOnCompositor to isThrottled or something? So that we can easily see that the animations are optimized in devtools. I am not sure it's useful for web developers, but I am convinced it's useful for use, developers (and contributers).
Comment 1•7 years ago
|
||
Yeah, this would be good because out-of-view animations don't run on the compositor so it's sometimes not clear in DevTools why a certain animation is not running on the compositor. Adding this flag would allow DevTools to provide more meaningful information in this case (perhaps it could just mark the animation as "fully optimized" if *either* it is running on the compositor *or* it is being throttled because it is out of view).
Reporter | ||
Comment 2•7 years ago
|
||
"fully optimized" sounds good to me. :)
Reporter | ||
Comment 3•7 years ago
|
||
FWIW, here is a patch that I have locally. I might be misunderstanding what Brian said about 'fully throttled'. Do'h! Now I realized the name what Brian said is 'fully optimized'. Sigh.. Anyway, in my understanding, the 'fully' means that the animation doesn't consume either the main thread or the compositor thread.
Reporter | ||
Comment 4•7 years ago
|
||
And this is a quick dirty patch to display a lighting bolt for the fully-throttled animations on devtools. With this patch I can detect unthrottled animations easily. :)
Updated•6 years ago
|
Priority: -- → P3
Comment 5•6 years ago
|
||
As per discussion with Daisuke on 04/10 and also for QA verification purposes this bug should also fix the side effect that the icon for fully-optimized/partial optimized is only visible when the animation is playing. (icon not visible when animation is paused or re-winded). If a separate bug should be logged for the above, please let me know.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•