1412744 - DevTools should not allow mutating rules in XBL stylesheets just like for UA sheets

Status: NEW

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

XBL stylesheets are not supposed to be changed, and there is no internal mechanism to notify all documents with the XBL component to restyle for the change.

XBL stylesheets should be handled like UA sheets that mutation is not allowed.

Comment 1

[Brian Grinstead [:bgrins]]

I'm not sure if you had the Style Editor or Inspector panel (or both) in mind here. FWIW I find editing the rules in the Inspector panel really useful and would be sad if that went away. I haven't noticed issues with the changes not being detected across documents but I believe it - XBL inspection in general is really buggy (as in Bug 1360072).

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

It is the Inspector panel when I'm filing this.

It would be quite mysterious if it works as expected... From the internal style system code, it doesn't seem to me that we are able to flush the style after changes to XBL stylesheets... unless devtools has its own logic to force a style flush after XBL rule changes?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It's possible it "works" because something else causes a style flush that happens to also apply changes to XBL from the Inspector.

If that's the case, it might help explain why it only seems to work "sometimes".