Closed Bug 1412778 Opened 2 years ago Closed 2 years ago

Enable ESLint rule no-cpows-in-tests across the whole tree

Categories

(Toolkit :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently no-cpows-in-tests is only enabled for a select set of directories.

We should get it enabled across the whole tree. There's about 219 instances that are currently failing. Since rewriting is likely to be difficult, we should whitelist those for now and try to stop more being added - bug 1351512 can then work on removing the remaining instances.
Comment on attachment 8923313 [details]
Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree.

https://reviewboard.mozilla.org/r/194514/#review199512

Unfortunate to have to disable the rule in some many files, but preventing new occurences from being introduced is a giant step in the right direction :-).
Attachment #8923313 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2157ae2dad27
Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
https://hg.mozilla.org/mozilla-central/rev/2157ae2dad27
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/953022f5c317e9331d0e18f68f9bfe376b9873e2
Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
See Also: → 1410416
You need to log in before you can comment on or make changes to this bug.