1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Mark Banner (:standard8)]

Currently no-cpows-in-tests is only enabled for a select set of directories.

We should get it enabled across the whole tree. There's about 219 instances that are currently failing. Since rewriting is likely to be difficult, we should whitelist those for now and try to stop more being added - bug 1351512 can then work on removing the remaining instances.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree.

Review commit: https://reviewboard.mozilla.org/r/194514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194514/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8923313 [details]
Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree.

https://reviewboard.mozilla.org/r/194514/#review199512

Unfortunate to have to disable the rule in some many files, but preventing new occurences from being introduced is a giant step in the right direction :-).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2157ae2dad27
Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2157ae2dad27

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/953022f5c317e9331d0e18f68f9bfe376b9873e2
Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian