1412784 - Fix broken searchplugin for hr (eudict), remove broken from vi (mp3.zing)

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Francesco Lodolo [:flod]]

The eudict searchplugin shipping in Croatian (hr) is broken. Fixing URLs and updating image.

https://mp3.zing.vn/ shipping in Vietnamese seems completely broken, not much of a point in shipping it.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1412784 - Fix broken searchplugins for Croatian (hr) and Vietname (vi)

- Update search URL and image for eudict.xml
- Removed zing-mp3.xml from Vietname, since the website content doesn't properly load

Review commit: https://reviewboard.mozilla.org/r/194520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194520/

Comment 2

[Mike Kaply [:mkaply]]

The zing problem is an expired cert for their static site, but search still work. I wouldn't remove it since they might fix?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #2)
> The zing problem is an expired cert for their static site, but search still
> work. I wouldn't remove it since they might fix?

It doesn't seem to be expired, but for the wrong domain (SSL_ERROR_BAD_CERT_DOMAIN)
https://zmp3-static.zadn.vn/

This makes me doubt the usefulness of the searchplugin, if nobody noticed the website is broken (also https://news.zing.vn/), unless I picked the wrong day to run my script.
https://en.wikipedia.org/wiki/VNG_Corporation#Zing_MP3

Happy to revert that change if you think that's useful.

Comment 4

[Mike Kaply [:mkaply]]

I emailed them. Let's give them a day or two. We can also check usage numbers.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #4)
> I emailed them. Let's give them a day or two. We can also check usage
> numbers.

Thanks, I think both are a great idea.

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 8923315 [details]
Bug 1412784 - Fix broken searchplugins for Croatian (hr) and Vietname (vi)

https://reviewboard.mozilla.org/r/194520/#review203818

Comment 7

[Mozilla Autoland]

hg error in cmd: hg update --clean -r c6099f497e32: abort: unknown revision 'c6099f497e32'!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a815ac782ef0
Fix broken searchplugins for Croatian (hr) and Vietname (vi) r=mkaply

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a815ac782ef0