Fix slider position of the tracking protection toggle button in RTL locales

VERIFIED FIXED in Firefox 59

Status

()

P3
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: magicp.jp, Assigned: groovecoder, Mentored)

Tracking

({good-first-bug, regression})

Trunk
Firefox 59
good-first-bug, regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox56 wontfix, firefox57 wontfix, firefox58 wontfix, firefox59 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8923316 [details]
tracking-protection-toggle-button-in-rtl.png

Steps to reproduce:
1. Start Firefox in RTL locales.
2. Open a new private window.
3. Check the tracking protection toggle button

Actual Results:
checked slider position is wrong.

Expected Results:
[aboutprivatebrowsing.css]
.toggle:checked + .toggle-btn:dir(rtl)::after {
  left: auto;
  right: 16px; <= should be 21px
}
(Reporter)

Updated

a year ago
Blocks: 1378799
status-firefox56: --- → affected
status-firefox57: --- → affected
The fix for this problem is described in comment 0. If you're not on an rtl language, you can just paste

document.body.dir = "rtl"

into the console on about:privatebrowsing to flip it.

The line to change is here: https://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css#161
Mentor: jhofmann
status-firefox56: affected → wontfix
status-firefox57: affected → wontfix
Flags: qe-verify+
Keywords: good-first-bug, regression
Priority: -- → P3
If offset-inline-start is enabled by default, we could also use that.
(Assignee)

Updated

a year ago
status-firefox59: --- → affected
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → lcrouch
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED

Comment 4

a year ago
mozreview-review
Comment on attachment 8929526 [details]
Bug 1412789 - fix tracking protection slider position in rtl

https://reviewboard.mozilla.org/r/200800/#review206136

Looks perfect, thank you!

::: commit-message-45715:1
(Diff revision 1)
> +fix tracking protection slider position in rtl (bug 1412789) r?johannh

Nit: The preferred commit message style is

Bug 1412789 - Fix tracking protection slider position in rtl. r?johannh
Attachment #8929526 - Flags: review?(jhofmann) → review+
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ee6a53be307
fix tracking protection slider position in rtl r=johannh

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ee6a53be307
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Please request Beta approval on this when you get a chance.
status-firefox-esr52: --- → unaffected
Flags: needinfo?(lcrouch)
(Assignee)

Updated

a year ago
status-firefox58: affected → wontfix
Flags: needinfo?(lcrouch)
Reproduced the issue on Nightly (2017-10-31) on Ubuntu 16.04 x64.

Verified fixed on latest Nightly (2017-12-05) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.