Closed Bug 1412789 Opened 3 years ago Closed 2 years ago

Fix slider position of the tracking protection toggle button in RTL locales

Categories

(Firefox :: Private Browsing, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- verified

People

(Reporter: magicp.jp, Assigned: groovecoder, Mentored)

References

Details

(Keywords: good-first-bug, regression)

Attachments

(2 files)

Steps to reproduce:
1. Start Firefox in RTL locales.
2. Open a new private window.
3. Check the tracking protection toggle button

Actual Results:
checked slider position is wrong.

Expected Results:
[aboutprivatebrowsing.css]
.toggle:checked + .toggle-btn:dir(rtl)::after {
  left: auto;
  right: 16px; <= should be 21px
}
The fix for this problem is described in comment 0. If you're not on an rtl language, you can just paste

document.body.dir = "rtl"

into the console on about:privatebrowsing to flip it.

The line to change is here: https://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css#161
Mentor: jhofmann
Flags: qe-verify+
Priority: -- → P3
If offset-inline-start is enabled by default, we could also use that.
Assignee: nobody → lcrouch
Status: NEW → ASSIGNED
Comment on attachment 8929526 [details]
Bug 1412789 - fix tracking protection slider position in rtl

https://reviewboard.mozilla.org/r/200800/#review206136

Looks perfect, thank you!

::: commit-message-45715:1
(Diff revision 1)
> +fix tracking protection slider position in rtl (bug 1412789) r?johannh

Nit: The preferred commit message style is

Bug 1412789 - Fix tracking protection slider position in rtl. r?johannh
Attachment #8929526 - Flags: review?(jhofmann) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ee6a53be307
fix tracking protection slider position in rtl r=johannh
https://hg.mozilla.org/mozilla-central/rev/9ee6a53be307
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Please request Beta approval on this when you get a chance.
Flags: needinfo?(lcrouch)
Flags: needinfo?(lcrouch)
Reproduced the issue on Nightly (2017-10-31) on Ubuntu 16.04 x64.

Verified fixed on latest Nightly (2017-12-05) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.